Refactor conda-builder -> almalinux-builder #140157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140157
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 464cb0d with merge base 8d61add ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
reviewed
Nov 8, 2024
.ci/docker/almalinux/Dockerfile
Outdated
There was a problem hiding this comment.
Shouldn't base image be an argument then? So that we can still build old ones, if needed as well as new oens?
There was a problem hiding this comment.
Oh, wow, I see, you did git cp, was a bit confused by the pattern
atalman
force-pushed
the
refactor_conda_builder_image
branch
from
b0e5cfb to
464cb0d
Compare
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
atalman
added a commit
to pytorch/test-infra
that referenced
this pull request
Nov 12, 2024
Use image build by: pytorch/pytorch#140157 This should support both Manylinux 2.28 wheels and old glibc 2.26 wheels. Tested by pulling Docker images and running some test. Test: ``` docker pull pytorch/almalinux-builder:cpu-main ``` Test Wheel build with Manylinux 2.28: ``` >>> import torch >>> from torch._C import * >>> torch.__version__ '2.6.0.dev20241106+cpu' ``` Test Wheel build with manylinux-builder: ``` >>> import torch >>> torch.__version__ '2.5.1+cu124' >>> from torch._C import * ``` Example of Glibc failure with wheels from 2024.11.06: https://github.com/pytorch/tensordict/actions/runs/11708894033/job/32611711890#step:12:734
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Something that was accidentally dropped by: #140157 Needs to be re-added. I believe its part of our Docker images. Please see: https://github.com/pytorch/pytorch/blob/main/.ci/docker/manywheel/Dockerfile#L21 Pull Request resolved: #140454 Approved by: https://github.com/seemethere, https://github.com/malfet
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
This changes the conda-builder workflow to almalinux-builder and switches Docker file to almalinux. Please note: Published conda-builder images will still be available, hence workflows that use these images will still work. We will be switching workflows that use conda-builder images to almalinux-builder Pull Request resolved: pytorch#140157 Approved by: https://github.com/malfet
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Something that was accidentally dropped by: pytorch#140157 Needs to be re-added. I believe its part of our Docker images. Please see: https://github.com/pytorch/pytorch/blob/main/.ci/docker/manywheel/Dockerfile#L21 Pull Request resolved: pytorch#140454 Approved by: https://github.com/seemethere, https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the conda-builder workflow to almalinux-builder and switches Docker file to almalinux.
Please note: Published conda-builder images will still be available, hence workflows that use these images will still work.
We will be switching workflows that use conda-builder images to almalinux-builder