KEMBAR78
[BE][CI] Use `pip3` instead of `pip` by malfet · Pull Request #140185 · pytorch/pytorch · GitHub
Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Nov 8, 2024

As on modern distros(see this oldie but goodie: https://launchpad.net/ubuntu/focal/+package/python-is-python3 ), pip alias might be missing or indeed point to Python2 installation

As on modern distros(see this oldie but goodie: https://launchpad.net/ubuntu/focal/+package/python-is-python3 ), `pip` alias might be missing or indeed point to Python2 installation
@malfet malfet requested a review from a team as a code owner November 8, 2024 22:13
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140185

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 015d323 with merge base 347f960 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Nov 8, 2024
@malfet malfet mentioned this pull request Nov 8, 2024
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might some more from docker build, but this LGTM!

@wdvr
Copy link
Contributor

wdvr commented Nov 8, 2024

See https://github.com/search?q=repo%3Apytorch%2Fpytorch+%22pip+install%22+NOT+language%3AMarkdown+OR+language%3AreStructuredText&type=code for remaining ones

@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 8, 2024
@malfet
Copy link
Contributor Author

malfet commented Nov 8, 2024

@pytorchbot merge -f "Lint is green and tests have started"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

atalman pushed a commit to atalman/pytorch that referenced this pull request Nov 11, 2024
As on modern distros(see this oldie but goodie: https://launchpad.net/ubuntu/focal/+package/python-is-python3 ), `pip` alias might be missing or indeed point to Python2 installation

Pull Request resolved: pytorch#140185
Approved by: https://github.com/wdvr, https://github.com/huydhn, https://github.com/seemethere
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
As on modern distros(see this oldie but goodie: https://launchpad.net/ubuntu/focal/+package/python-is-python3 ), `pip` alias might be missing or indeed point to Python2 installation

Pull Request resolved: pytorch#140185
Approved by: https://github.com/wdvr, https://github.com/huydhn, https://github.com/seemethere
@github-actions github-actions bot deleted the malfet-patch-3 branch December 10, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: releng release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants