Fix triangular_solve meta function out parameter names.
#140186
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140186
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bded981 with merge base ffb9790 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ysiraichi
added a commit
that referenced
this pull request
Nov 8, 2024
This PR replaces the parameter names specified in the `triangular_solve_meta`
function (specifically in its `out_wrapper(...)` decorator) by those written in the
_native_functions.yaml_ file.
This name mismatch caused the operation to fail when using the meta device (see error
below):
```python
Traceback (most recent call last):
File "examples/test.py", line 23, in <module>
torch.triangular_solve(b.to("meta"), A.to("meta"), out=meta_out)
File "torch/_decomp/__init__.py", line 100, in _fn
return f(*args, **kwargs, out=None if is_none else out_kwargs)
File "torch/_prims_common/wrappers.py", line 289, in _fn
result = fn(*args, **kwargs)
TypeError: triangular_solve_meta() got an unexpected keyword argument 'X'
```
ghstack-source-id: 1fa2de5
Pull Request resolved: #140186
ysiraichi
added a commit
that referenced
this pull request
Nov 9, 2024
This PR replaces the parameter names specified in the `triangular_solve_meta`
function (specifically in its `out_wrapper(...)` decorator) by those written in the
_native_functions.yaml_ file.
This name mismatch caused the operation to fail when using the meta device (see error
below):
```python
Traceback (most recent call last):
File "examples/test.py", line 23, in <module>
torch.triangular_solve(b.to("meta"), A.to("meta"), out=meta_out)
File "torch/_decomp/__init__.py", line 100, in _fn
return f(*args, **kwargs, out=None if is_none else out_kwargs)
File "torch/_prims_common/wrappers.py", line 289, in _fn
result = fn(*args, **kwargs)
TypeError: triangular_solve_meta() got an unexpected keyword argument 'X'
```
ghstack-source-id: 67cdf96
Pull Request resolved: #140186
This was referenced Nov 11, 2024
ezyang
approved these changes
Nov 12, 2024
|
what's with the new xfail? |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
So, before this PR, the meta consistency test wasn't failing because both meta and CPU devices were raising error. Different errors, though:
After fixing the meta error, meta stopped raising an error. Which means that it's not consistent with its CPU version anymore. The next PR in this stack fixes the consistency error, deleting the XFAIL. |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 14, 2024
…140286) Tracking issue: #138399 Pull Request resolved: #140286 Approved by: https://github.com/ezyang ghstack dependencies: #140186
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 18, 2024
Tracking issue: #138399 This PR fixes a number of reference implementations (which are also used as meta functions), making them more consistent with CPU device. More specifically, it fixes those operations that use `_make_elementwise_unary_reference` decorator, and don't error on mismatching out argument dtype while they error when using concrete devices (e.g. CPU). The fixed operations are: - `abs` - `ceil` - `floor` - `frac` - `isneginf` - `isposinf` - `sgn` - `sign` - `signbit` - `trunc` Pull Request resolved: #140288 Approved by: https://github.com/ezyang ghstack dependencies: #140186, #140286
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…0186) This PR replaces the parameter names specified in the `triangular_solve_meta` function (specifically in its `@out_wrapper(...)` decorator) by those written in the _native_functions.yaml_ file. This name mismatch caused the operation to fail when using the meta device (see error below): ```python Traceback (most recent call last): File "examples/test.py", line 23, in <module> torch.triangular_solve(b.to("meta"), A.to("meta"), out=meta_out) File "torch/_decomp/__init__.py", line 100, in _fn return f(*args, **kwargs, out=None if is_none else out_kwargs) File "torch/_prims_common/wrappers.py", line 289, in _fn result = fn(*args, **kwargs) TypeError: triangular_solve_meta() got an unexpected keyword argument 'X' ``` Pull Request resolved: pytorch#140186 Approved by: https://github.com/ezyang
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…ytorch#140286) Tracking issue: pytorch#138399 Pull Request resolved: pytorch#140286 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#140186
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Tracking issue: pytorch#138399 This PR fixes a number of reference implementations (which are also used as meta functions), making them more consistent with CPU device. More specifically, it fixes those operations that use `_make_elementwise_unary_reference` decorator, and don't error on mismatching out argument dtype while they error when using concrete devices (e.g. CPU). The fixed operations are: - `abs` - `ceil` - `floor` - `frac` - `isneginf` - `isposinf` - `sgn` - `sign` - `signbit` - `trunc` Pull Request resolved: pytorch#140288 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#140186, pytorch#140286
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…h#140289) Tracking issue: pytorch#138399 Pull Request resolved: pytorch#140289 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#140186, pytorch#140286, pytorch#140288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
log_softmax: fix meta function output argument dtype check. #140289triangular_solve: fix meta function output argument dtype check. #140286triangular_solvemeta function out parameter names. #140186This PR replaces the parameter names specified in the
triangular_solve_metafunction (specifically in its
@out_wrapper(...)decorator) by those written in thenative_functions.yaml file.
This name mismatch caused the operation to fail when using the meta device (see error
below):