KEMBAR78
[MPS] Add `torch.special.i1` op by malfet · Pull Request #140196 · pytorch/pytorch · GitHub
Skip to content

[MPS] Add torch.special.i1 op #140196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[MPS] Add torch.special.i1 op #140196

wants to merge 3 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Nov 9, 2024 •
edited
Loading

By more-or-less copy-n-pasting

pytorch/aten/src/ATen/native/cuda/Math.cuh

Line 576 in 58b661c

T i1(T _x) {

Enable respective tests in test_mps.py

@malfet malfet requested a review from kulinseth as a code owner November 9, 2024 00:27
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140196

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9e8b57c with merge base d72a308 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Nov 9, 2024
@malfet malfet requested a review from manuelcandales November 9, 2024 00:27
@malfet malfet added the topic: improvements topic category label Nov 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

Skylion007
Skylion007 reviewed Nov 9, 2024
View reviewed changes
@malfet
Copy link
Contributor Author

malfet commented Nov 11, 2024

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@malfet
[MPS] Add torch.special.i1 op (pytorch#140196)
986165f 
By more-or-less copy-n-pasting https://github.com/pytorch/pytorch/blob/58b661cda2c002a8e1ac3bee494bfe1f7420437c/aten/src/ATen/native/cuda/Math.cuh#L576

Enable respective tests in test_mps.py
Pull Request resolved: pytorch#140196
Approved by: https://github.com/Skylion007
@github-actions github-actions bot deleted the malfet/mps-add-i1-op branch December 12, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@manuelcandales manuelcandales Awaiting requested review from manuelcandales

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @pytorchmergebot @Skylion007