-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[BE][Bugfix]: Add rad2deg to pointwise ops #140290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE][Bugfix]: Add rad2deg to pointwise ops #140290
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140290
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 010fa5e with merge base 10e40dd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
f7ddd55 to
010fa5e
Compare
|
@jbschlosser Yeah, the pointwise tag fixes the xfail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge -f "green light everywhere else" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Adds missing pontwise tags. Apparently this allows NestedTensor to properly generate a function for opinfo Pull Request resolved: pytorch#140290 Approved by: https://github.com/jbschlosser
Adds missing pontwise tags. Apparently this allows NestedTensor to properly generate a function for opinfo Pull Request resolved: pytorch#140290 Approved by: https://github.com/jbschlosser
Adds missing pontwise tags. Apparently this allows NestedTensor to properly generate a function for opinfo Pull Request resolved: pytorch#140290 Approved by: https://github.com/jbschlosser
Adds missing pontwise tags. Apparently this allows NestedTensor to properly generate a function for opinfo