KEMBAR78
[BE][Bugfix]: Add rad2deg to pointwise ops by Skylion007 · Pull Request #140290 · pytorch/pytorch · GitHub
Skip to content

Conversation

@Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Nov 11, 2024

Adds missing pontwise tags. Apparently this allows NestedTensor to properly generate a function for opinfo

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140290

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 010fa5e with merge base 10e40dd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

@Skylion007 Skylion007 force-pushed the skylion007/add-rad2deg-pointwise-2024-11-11 branch from f7ddd55 to 010fa5e Compare November 11, 2024 20:21
@Skylion007
Copy link
Collaborator Author

@jbschlosser Yeah, the pointwise tag fixes the xfail

@Skylion007 Skylion007 added better-engineering Relatively self-contained tasks for better engineering contributors topic: bug fixes topic category labels Nov 12, 2024
@jbschlosser jbschlosser added the topic: not user facing topic category label Nov 12, 2024
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jbschlosser
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 12, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007 Skylion007 added release notes: nested tensor Changes that have a direct impact on nested tensors and removed topic: not user facing topic category labels Nov 12, 2024
@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@Skylion007
Copy link
Collaborator Author

@pytorchbot merge -f "green light everywhere else"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

zhangxiaoli73 pushed a commit to zhangxiaoli73/pytorch that referenced this pull request Nov 13, 2024
Adds missing pontwise tags. Apparently this allows NestedTensor to properly generate a function for opinfo
Pull Request resolved: pytorch#140290
Approved by: https://github.com/jbschlosser
zero000064 pushed a commit to zero000064/pytorch that referenced this pull request Nov 14, 2024
Adds missing pontwise tags. Apparently this allows NestedTensor to properly generate a function for opinfo
Pull Request resolved: pytorch#140290
Approved by: https://github.com/jbschlosser
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Adds missing pontwise tags. Apparently this allows NestedTensor to properly generate a function for opinfo
Pull Request resolved: pytorch#140290
Approved by: https://github.com/jbschlosser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nested tensor Changes that have a direct impact on nested tensors topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants