Benchmarks dynamo update script to use ClickHouse instead of Rockset #140574
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140574
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit f8c667e with merge base 2675ef8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| data=json.dumps(params), | ||
| headers={"Content-Type": "application/json"}, | ||
| # This key can only access query endpoints, specifically the url above at the moment | ||
| auth=("eJBpUENTBQ4MdbHPYxrl", "4b1draOBY5zwva7QXTBgAwqbYrpNKFaXGNYqASt5a9"), |
There was a problem hiding this comment.
I guess this is a read-only key, but I think we should still keep it a secret as this looks like an open invitation to people trying to gain access or ddos our query endpoint
There was a problem hiding this comment.
How do you propose distributing the key to everyone who wants to run this script?
There was a problem hiding this comment.
I think we should make a request to CH to see if they allow no-auth read-only request to their API endpoint like what Rockset gives us. Another solution that doesn't block us is to create a simple API on HUD that forward the queries to CH and returns the results, we can then keep the read-only secret on Vercel
There was a problem hiding this comment.
Don't these solutions have the same problem as before?
There was a problem hiding this comment.
Removed the credentials an put a link to them instead
|
@pytorchbot merge -f "no trunk needed" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ytorch#140574) Query works but the part where it parses the job name is broken Pull Request resolved: pytorch#140574 Approved by: https://github.com/huydhn
3 participants
Query works but the part where it parses the job name is broken
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames