Port X86_F16 from executorch half to PyTorch half #140720
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140720
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
✅ No FailuresAs of commit 15edd3c with merge base 891ba2e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 14, 2024
|
This pull request was exported from Phabricator. Differential Revision: D65949409 |
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65949409 |
swolchok
added a commit
that referenced
this pull request
Nov 14, 2024
Pull Request resolved: #140720 This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. ghstack-source-id: 253592160 @exported-using-ghexport Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/)
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65949409 |
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65949409 |
swolchok
added a commit
that referenced
this pull request
Nov 15, 2024
Pull Request resolved: #140720 This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. ghstack-source-id: 253813016 @exported-using-ghexport Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/)
swolchok
added
release notes: performance_as_product
release notes: cpp
|
I think this one is not ready for land yet; surprised checks pass because I think I'm seeing a failure internally. need to investigate |
malfet
approved these changes
Nov 18, 2024
malfet
reviewed
Nov 18, 2024
| #if defined(__x86_64__) || defined(_M_X64) || defined(__i386) || \ | ||
| defined(_M_IX86) | ||
| #if defined(__F16C__) | ||
| #define X86_F16 1 |
There was a problem hiding this comment.
Should it be something like _HAS_X86_64_F16 (to avoid even a slight possibility of name collision)
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
This pull request was exported from Phabricator. Differential Revision: D65949409 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D65949409 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 19, 2024
It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) Pull Request resolved: #140994 Approved by: https://github.com/malfet ghstack dependencies: #140564, #140565, #140566, #140567, #140720
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 19, 2024
Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: #141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: #140564, #140565, #140566, #140567, #140720, #140994
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature. Differential Revision: [D65949409](https://our.internmc.facebook.com/intern/diff/D65949409/) Pull Request resolved: pytorch#140720 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
It passed PyTorch CI, but internally we saw failures from this. Differential Revision: [D66137897](https://our.internmc.facebook.com/intern/diff/D66137897/) Pull Request resolved: pytorch#140994 Approved by: https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Make what we're doing as obvious as possible to the compiler. Differential Revision: [D66108811](https://our.internmc.facebook.com/intern/diff/D66108811/) Pull Request resolved: pytorch#141035 Approved by: https://github.com/Skylion007, https://github.com/ezyang, https://github.com/malfet ghstack dependencies: pytorch#140564, pytorch#140565, pytorch#140566, pytorch#140567, pytorch#140720, pytorch#140994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This was added in pytorch/executorch#1789 . I'm working on sharing Half.h with ExecuTorch, and this is a missing feature.
Differential Revision: D65949409