Flex + NJT: cross attention support #140723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
jbschlosser
requested review from
albanD and
mikaylagawarecki
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140723
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
✅ No FailuresAs of commit 35d6575 with merge base 2675ef8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jbschlosser
added
topic: improvements
jbschlosser
requested review from
cpuhrsch,
drisspg and
soulitzer
and removed request for
albanD
Fixes #140598 Allows ragged structures for query and key+value to differ (i.e. supports cross attention for Flex + NJT). Technically, this is BC-breaking thanks to positional arg reordering in `create_nested_block_mask()`, but Flex + NJT support isn't in a major release yet so I'm hoping we can just do it. [ghstack-poisoned]
jbschlosser
added
the
suppress-bc-linter
Fixes #140598 Allows ragged structures for query and key+value sequence lengths to differ (i.e. supports cross attention for Flex + NJT). Technically, this is BC-breaking thanks to arg renaming and positional arg reordering in `create_nested_block_mask()`, but Flex + NJT support isn't in a major release yet so I'm hoping we can just do it. [ghstack-poisoned]
drisspg
approved these changes
Nov 15, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
c-p-i-o
pushed a commit
to c-p-i-o/pytorch
that referenced
this pull request
Nov 18, 2024
Fixes pytorch#140598 Allows ragged structures for query and key+value sequence lengths to differ (i.e. supports cross attention for Flex + NJT). Technically, this is BC-breaking thanks to arg renaming and positional arg reordering in `create_nested_block_mask()`, but Flex + NJT support isn't in a major release yet so I'm hoping we can just do it. Pull Request resolved: pytorch#140723 Approved by: https://github.com/drisspg
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Fixes pytorch#140598 Allows ragged structures for query and key+value sequence lengths to differ (i.e. supports cross attention for Flex + NJT). Technically, this is BC-breaking thanks to arg renaming and positional arg reordering in `create_nested_block_mask()`, but Flex + NJT support isn't in a major release yet so I'm hoping we can just do it. Pull Request resolved: pytorch#140723 Approved by: https://github.com/drisspg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #140598
Allows ragged structures for query and key+value sequence lengths to differ (i.e. supports cross attention for Flex + NJT).
Technically, this is BC-breaking thanks to arg renaming and positional arg reordering in
create_nested_block_mask(), but Flex + NJT support isn't in a major release yet so I'm hoping we can just do it.