KEMBAR78
Add some symbolic shapes guard logs to tlparse by default by ezyang · Pull Request #140867 · pytorch/pytorch · GitHub
Skip to content

Add some symbolic shapes guard logs to tlparse by default #140867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add some symbolic shapes guard logs to tlparse by default #140867

wants to merge 2 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Nov 16, 2024 •
edited by pytorch-bot bot
Loading

@ezyang
Update
2c18831 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140867

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 247ba8e with merge base 44186a0 (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Nov 16, 2024
@ezyang
Add some symbolic shapes guard logs to tlparse by default
fd0bc0e 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 319bc9e
Pull Request resolved: #140867
@pytorch-bot pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels Nov 16, 2024
bdhirsh
bdhirsh reviewed Nov 18, 2024
View reviewed changes
torch/fx/experimental/symbolic_shapes.py
stack_info=is_debug,
)
trace_structured(
"create_unbacked_symbol",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it still the case that each of these new string names ("create_unbacked_symbol") requires patches to tlparse to get working? (and trace_structured("artifact", ...) is the blessed way to add new artifacts without needing tlparse changes)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I intentionally don't want artifacts for these because you will completely flood the artifact list (you're talking O(100) events here

@ezyang
Copy link
Contributor Author

ezyang commented Nov 20, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Nov 21, 2024

wut

@ezyang
Copy link
Contributor Author

ezyang commented Nov 26, 2024

Thwarted by TD!

@ezyang ezyang mentioned this pull request Nov 26, 2024
Open
@ezyang
Update
247ba8e 
[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Nov 26, 2024

@pytorchbot merge

ezyang added a commit that referenced this pull request Nov 26, 2024
@ezyang
Add some symbolic shapes guard logs to tlparse by default
f6e4dac 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: 518537e
Pull Request resolved: #140867
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ezyang
Copy link
Contributor Author

ezyang commented Nov 27, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: inductor / cuda12.4-py3.10-gcc9-sm86 / test (inductor_timm, 1, 2, linux.g5.4xlarge.nvidia.gpu, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@ezyang
Add some symbolic shapes guard logs to tlparse by default (pytorch#14…
e32883d 
…0867)

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: pytorch#140867
Approved by: https://github.com/bdhirsh
@github-actions github-actions bot deleted the gh/ezyang/3001/head branch December 27, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fx Merged module: dynamo release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @bdhirsh @facebook-github-bot