[inductor] Refactor ir.Layout into ir.OutputSpec #140910
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/140910
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 20d94d8 with merge base 260d1dc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jansel
changed the title
ezyang
reviewed
Nov 21, 2024
| query.get_dtype(), | ||
| [B, Hq, seq_len_q, v_head_dim], | ||
| stride=out_strides, | ||
| stride=[sympy.sympify(s) for s in out_strides], |
ezyang
approved these changes
Nov 21, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 21, 2024
Pull Request resolved: #140912 Approved by: https://github.com/aorenste ghstack dependencies: #140895, #140910
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
This separate the concepts of a Layout (size/stride/etc) and an OutputSpec (which includes multiple outputs). Which should make typing easier. Pull Request resolved: pytorch#140910 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#140895
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Pull Request resolved: pytorch#140912 Approved by: https://github.com/aorenste ghstack dependencies: pytorch#140895, pytorch#140910
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This separate the concepts of a Layout (size/stride/etc) and an OutputSpec (which includes multiple outputs). Which should make typing easier.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov