[dynamic] Reduce stack trace logs in symbolic_shape #141068
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D66196982
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141068
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 7768b8c with merge base 32e93df ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D66196982 |
ezyang
approved these changes
Nov 20, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Motivation: pytorch#139408 To reduce excessive warning logs. You can get back previous behavior by prepending `TORCH_LOGS="dynamic" ` repro: pytorch#139408 after: ``` /torch/fx/experimental/symbolic_shapes.py:6452] runtime_asserts_frozen but then got 3*TruncToInt(IntTrueDiv(s0, 1))*TruncToInt(IntTrueDiv(s1, 1)) < 2147483648 /torch/fx/experimental/symbolic_shapes.py:6032] Ignored guard 3*TruncToInt(IntTrueDiv(s0, 1))*TruncToInt(IntTrueDiv(s1, 1)) < 2147483648 == True, this could result in accuracy problems /torch/fx/experimental/symbolic_shapes.py:6452] runtime_asserts_frozen but then got 2*s0*s1 + s1*(s0 - 1) + s1 < 2147483648 /torch/fx/experimental/symbolic_shapes.py:6032] Ignored guard 2*s0*s1 + s1*(s0 - 1) + s1 < 2147483648 == True, this could result in accuracy problems ``` before: 174 lines Differential Revision: D66196982 Pull Request resolved: pytorch#141068 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: #139408
To reduce excessive warning logs. You can get back previous behavior by prepending
TORCH_LOGS="dynamic"repro: #139408
after:
before: 174 lines
Differential Revision: D66196982
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv