KEMBAR78
[BE][Ez]: Reserve vector for NT GEMM Matmul by Skylion007 · Pull Request #141130 · pytorch/pytorch · GitHub
Skip to content

Conversation

@Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Nov 20, 2024

Easy fix to missing reserve calls in NT Matmul CUDA kernel to improve perf.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141130

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 3fa9708 with merge base a440a01 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: cuda release notes category label Nov 20, 2024
@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label Nov 20, 2024
@Skylion007 Skylion007 force-pushed the skylion007/nested-tensor-matmul-reserve-2024-11-20 branch from 2136ede to 2767e0f Compare November 20, 2024 14:49
@Skylion007 Skylion007 force-pushed the skylion007/nested-tensor-matmul-reserve-2024-11-20 branch from 2767e0f to e1a031f Compare November 20, 2024 15:24
@Skylion007 Skylion007 force-pushed the skylion007/nested-tensor-matmul-reserve-2024-11-20 branch from e1a031f to 3fa9708 Compare November 20, 2024 15:25
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though would be nice to add a comment, that PR is aimed at improving the perf.

@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Easy fix to missing reserve calls in NT Matmul CUDA kernel to improve perf.
Pull Request resolved: pytorch#141130
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: cuda release notes category topic: improvements topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants