[c10d] Switch all timer logging in c10d to wait_counter #141154
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141154
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b9640bb with merge base d5ee1d1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
|
This pull request was exported from Phabricator. Differential Revision: D66218675 |
Summary: The original decorator based time logger is bad in performance and capacity. So we want to replace it with pytorch `_WaitCounter` now. Test Plan: Tested on workload and no regression has been seen: https://fburl.com/scuba/aps_instrumentation_components/mskj73ea time counter can be seen here in https://fburl.com/canvas/z2lm3mc4 Reviewed By: wz337 Differential Revision: D66218675
fduwjj
force-pushed
the
export-D66218675
branch
from
1e052c6 to
b9640bb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66218675 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: The original decorator based time logger is bad in performance and capacity. So we want to replace it with pytorch `_WaitCounter` now. Test Plan: Tested on workload and no regression has been seen: https://fburl.com/scuba/aps_instrumentation_components/mskj73ea Differential Revision: D66218675 Pull Request resolved: pytorch#141154 Approved by: https://github.com/wz337
4 participants
Summary: The original decorator based time logger is bad in performance and capacity. So we want to replace it with pytorch
_WaitCounternow.Test Plan: Tested on workload and no regression has been seen: https://fburl.com/scuba/aps_instrumentation_components/mskj73ea
Differential Revision: D66218675
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @wz337 @wconstab @d4l3k @c-p-i-o