[FlexAttention] Fix another IMA with captured buffers #141164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141164
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 Unrelated FailureAs of commit 2180591 with merge base 2ee2dcb ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added
topic: not user facing
Chillee
approved these changes
Nov 21, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 21, 2024
# Summary Previous custom op library name was a little verbose and didn't really align with how we typically name our libraries. Pull Request resolved: #141185 Approved by: https://github.com/Chillee ghstack dependencies: #141164
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 22, 2024
# Summary ### Before ```Shell 48.71s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` ### After Speeds up grad check tests by 10x ```Shell 4.74s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` Pull Request resolved: #141356 Approved by: https://github.com/BoyuanFeng ghstack dependencies: #141164, #141185
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
# Summary We have another IMA for captured buffers when we are the sequences are not divisible. Running test before this commit: ```Shell ========= Error: process didn't terminate successfully ========= Target application returned an error ========= ERROR SUMMARY: 447 errors ========= ERROR SUMMARY: 347 errors were not printed. Use --print-limit option to adjust the number of printed errors ``` And After ```Shell ❯ CUDA_LAUNCH_BLOCKING=1 PYTORCH_NO_CUDA_MEMORY_CACHING=1 compute-sanitizer --tool memcheck pytest test/inductor/test_flex_attention.py -k "test_non_divisible_with_captured_buffer" ========= COMPUTE-SANITIZER ====================================================== test session starts ======================================================= platform linux -- Python 3.12.7, pytest-7.4.0, pluggy-1.5.0 rootdir: /home/drisspg/meta/pytorch configfile: pytest.ini plugins: hypothesis-6.115.5, typeguard-4.3.0 collected 518 items / 517 deselected / 1 selected Running 1 items in this shard test/inductor/test_flex_attention.py . [100%] =============================================== 1 passed, 517 deselected in 13.31s =============================================== ========= ERROR SUMMARY: 0 errors ``` Pull Request resolved: pytorch#141164 Approved by: https://github.com/Chillee
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
# Summary Previous custom op library name was a little verbose and didn't really align with how we typically name our libraries. Pull Request resolved: pytorch#141185 Approved by: https://github.com/Chillee ghstack dependencies: pytorch#141164
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
# Summary ### Before ```Shell 48.71s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` ### After Speeds up grad check tests by 10x ```Shell 4.74s call test/inductor/test_flex_attention.py::TestFlexAttention::test_captured_score_mod_aot_eager_gradcheck_score_mod_name__head_offset_mode_aot_eager ``` Pull Request resolved: pytorch#141356 Approved by: https://github.com/BoyuanFeng ghstack dependencies: pytorch#141164, pytorch#141185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
We have another IMA for captured buffers when we are the sequences are not divisible.
Running test before this commit:
And After
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov @Chillee @yanboliang @BoyuanFeng