KEMBAR78
Migrate pull jobs cuda12.1->cuda12.4 by atalman · Pull Request #141271 · pytorch/pytorch · GitHub
Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Nov 21, 2024

Cuda 12.1 nightly builds where deprecated. Hence no reason on keep testing cuda 12.1 in CI

@atalman atalman requested a review from a team as a code owner November 21, 2024 19:47
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 21, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141271

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit e695cd1 with merge base a847790 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@tinglvv
Copy link
Collaborator

tinglvv commented Nov 21, 2024

Thanks for the update 👍

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we migrate existing 12.4 to 12.6 then?

@huydhn
Copy link
Contributor

huydhn commented Nov 21, 2024

Shouldn't we migrate existing 12.4 to 12.6 then?

There are a number of existing CUDA 12.4 that should either be cleaned up or updated to 12.6, for example:

(There might be more of them)

@atalman
Copy link
Contributor Author

atalman commented Nov 21, 2024

@atalman
Copy link
Contributor Author

atalman commented Nov 21, 2024

@huydhn I believe @tinglvv will be looking into adding 12.6 CI jobs.

@atalman
Copy link
Contributor Author

atalman commented Nov 21, 2024

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Cuda 12.1 nightly builds where deprecated. Hence no reason on keep testing cuda 12.1 in CI
Pull Request resolved: pytorch#141271
Approved by: https://github.com/Skylion007, https://github.com/malfet, https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants