KEMBAR78
[dynamo] Trace through `dataclasses` by removing it from `BUILTIN_SKIPLIST` by StrongerXi · Pull Request #141294 · pytorch/pytorch · GitHub
Skip to content

[dynamo] Trace through dataclasses by removing it from BUILTIN_SKIPLIST #141294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[dynamo] Trace through dataclasses by removing it from BUILTIN_SKIPLIST #141294

wants to merge 2 commits into from

Conversation

@StrongerXi
Copy link
Contributor

@StrongerXi StrongerXi commented Nov 21, 2024 •
edited by pytorch-bot bot
Loading

@StrongerXi
Update
4fd1e8f 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141294

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 4e45e29 with merge base d0fd42e (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

StrongerXi added a commit that referenced this pull request Nov 21, 2024
@StrongerXi
[dynamo] Trace through dataclasses by removing it from `BUILTIN_SKI…
544cc26 
…PLIST`

Fixes #141261.

ghstack-source-id: d77ab58
Pull Request resolved: #141294
@StrongerXi
Copy link
Contributor Author

Let's see what CI says.

@StrongerXi StrongerXi linked an issue Nov 21, 2024 that may be closed by this pull request
[dynamo] Trace through dataclasses functions #141261
Closed
@StrongerXi
Update
4e45e29 
[ghstack-poisoned]
StrongerXi added a commit that referenced this pull request Nov 25, 2024
@StrongerXi
[dynamo] Trace through dataclasses by removing it from `BUILTIN_SKI…
4dc6b5f 
…PLIST`

Fixes #141261.

ghstack-source-id: e56235e
Pull Request resolved: #141294
@StrongerXi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 26, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@StrongerXi
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@williamwen42 williamwen42 mentioned this pull request Dec 3, 2024
Closed
@StrongerXi StrongerXi mentioned this pull request Dec 3, 2024
Closed
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@StrongerXi
[dynamo] Trace through dataclasses by removing it from `BUILTIN_SKI…
cbaeb9d 
…PLIST` (pytorch#141294)

Fixes pytorch#141261.

Pull Request resolved: pytorch#141294
Approved by: https://github.com/williamwen42, https://github.com/jansel
@github-actions github-actions bot deleted the gh/StrongerXi/41/head branch December 27, 2024 02:06
@StrongerXi StrongerXi mentioned this pull request Feb 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@williamwen42 williamwen42 williamwen42 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo release notes: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[dynamo] Trace through dataclasses functions

4 participants

@StrongerXi @pytorchmergebot @jansel @williamwen42