KEMBAR78
[fx] make split_module work with keep_original_order=True and no-op graph by kshitij12345 · Pull Request #141340 · pytorch/pytorch · GitHub
Skip to content

[fx] make split_module work with keep_original_order=True and no-op graph #141340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[fx] make split_module work with keep_original_order=True and no-op graph #141340

wants to merge 4 commits into from

Conversation

@kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Nov 22, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 22, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141340

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8ebc0a4 with merge base 3473dfa (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Nov 22, 2024
@kshitij12345 kshitij12345 marked this pull request as draft November 22, 2024 10:51
@kshitij12345 kshitij12345 marked this pull request as ready for review November 22, 2024 13:31
@kshitij12345 kshitij12345 requested a review from ezyang November 22, 2024 13:31
@kshitij12345
Copy link
Collaborator Author

Linter error seems unrelated as it is pointing to files unchanged in this PR and other errors seem to be happening on main (based on this comment)

ezyang
ezyang approved these changes Nov 24, 2024
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand this patch, but it seems harmless enough

@ezyang
Copy link
Contributor

ezyang commented Nov 24, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 24, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@kshitij12345
[fx] make split_module work with keep_original_order=True and no-op g…
8e7e2f5 
…raph (pytorch#141340)

Fixes pytorch#140014

Pull Request resolved: pytorch#141340
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fx Merged open source release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[fx] split_module fails with no-op graph and keep_original_order=True

5 participants

@kshitij12345 @ezyang @pytorchmergebot @facebook-github-bot @pytorchbot