automatic_dynamic_shapes_mark_as #141415
Closed
automatic_dynamic_shapes_mark_as #141415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
added a commit
that referenced
this pull request
Nov 23, 2024
This adds an option to cause automatic dynamic shapes to trigger unbacked SymInts rather than backed SymInts. This can potentially help if you are still seeing recompilations from 0/1 specialization but it also might just cause your program to fail with GuardOnDataDependent errors. Signed-off-by: Edward Z. Yang <ezyang@meta.com> ghstack-source-id: a3ca847 Pull Request resolved: #141415
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141415
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7df218a with merge base dd2d0c6 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
ezyang
added
topic: new features
|
Can you elaborate on the tradeoffs between this and the more explicit path of having a flag like |
I'm not sure exactly what you're proposing with |
This was referenced Nov 24, 2024
bobrenjc93
approved these changes
Nov 26, 2024
ezyang
changed the title
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 11, 2024
Fixes #137100 Should also add a mark_oblivious API for manual control. Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: #141444 Approved by: https://github.com/bobrenjc93 ghstack dependencies: #141415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This adds an option to cause automatic dynamic shapes to trigger
unbacked SymInts rather than backed SymInts. This can potentially
help if you are still seeing recompilations from 0/1 specialization
but it also might just cause your program to fail with
GuardOnDataDependent errors.
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames