-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[MPS] Add MetalShaderLibrary::getFunctionNames()
#141499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141499
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit e884a79 with merge base 2398e75 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
MetalShaderLibrary::getFunctionNames()
That returns names of all the function in shader [ghstack-poisoned]
| } | ||
| std::vector<std::string> rc; | ||
| @autoreleasepool { | ||
| NSArray<NSString*>* names = [getLibrary() functionNames]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| NSArray<NSString*>* names = [getLibrary() functionNames]; | |
| NSArray<NSString*>* names = [getLibrary() functionNames]; | |
| rc.reserve([names count]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, modulo nits.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge -f "No MacOS15 runners available" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
That returns names of all the function in shader Pull Request resolved: pytorch#141499 Approved by: https://github.com/manuelcandales, https://github.com/Skylion007 ghstack dependencies: pytorch#141474, pytorch#141475, pytorch#141476, pytorch#141477
ghstack-source-id: f74416c Pull Request resolved: pytorch/pytorch#141499
Stack from ghstack (oldest at bottom):
MetalShaderLibrary::getFunctionNames()#141499That returns names of all the function in shader