KEMBAR78
handle sympy.oo in bitwise_and/or value_ranges by williamwen42 · Pull Request #141522 · pytorch/pytorch · GitHub
Skip to content

handle sympy.oo in bitwise_and/or value_ranges #141522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

handle sympy.oo in bitwise_and/or value_ranges #141522

wants to merge 1 commit into from

Conversation

@williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Nov 25, 2024 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

An internal test is failing due to not handling sympy.oo properly in bitwise_and/or value_ranges: T208684142. I don't know how to repro this - seems like this requires inductor to trigger as well.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @ezyang @penguinwu @bobrenjc93

@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Nov 25, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141522

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit b1b8a32 with merge base e54538a (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • linux-binary-manywheel / manywheel-py3_9-cuda11_8-test / test (gh) (trunk failure)
    ERROR: Could not find a version that satisfies the requirement pytorch-triton==3.2.0+35c6c7c628; platform_system == "Linux" and platform_machine == "x86_64" and python_version < "3.13" (from torch) (from versions: 2.0.0+0d7e753227, 2.0.0+3aa3d7024e, 2.0.0+af76c989eb, 2.0.0+b8b470bc59, 2.0.0+c8bfe3f548, 2.0.0+d54c04abe2, 2.1.0, 2.1.0+2c32f43999, 2.1.0+3c400e7818, 2.1.0+440fd1bf20, 2.1.0+46672772b4, 2.1.0+6e4932cda8, 2.1.0+7d1a95b046, 2.1.0+9820899b38, 2.1.0+9e3e10c5ed, 2.1.0+bcad9dabe1, 2.1.0+e6216047b8, 2.1.0+e650d3708b, 2.2.0+e28a256d71, 3.0.0+45fff310c8, 3.0.0+757b6a61e7, 3.0.0+901819d2b6, 3.0.0+989adb9a29, 3.0.0+a9bc1a3647, 3.0.0+dedb7bdf33, 3.1.0+5fe38ffd73, 3.1.0+cf34004b8a, 3.2.0+git35c6c7c6)
  • linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test (gh) (trunk failure)
    ERROR: Could not find a version that satisfies the requirement pytorch-triton==3.2.0+35c6c7c628; platform_system == "Linux" and platform_machine == "x86_64" and python_version < "3.13" (from torch) (from versions: 2.0.0+0d7e753227, 2.0.0+3aa3d7024e, 2.0.0+af76c989eb, 2.0.0+b8b470bc59, 2.0.0+c8bfe3f548, 2.0.0+d54c04abe2, 2.1.0, 2.1.0+2c32f43999, 2.1.0+3c400e7818, 2.1.0+440fd1bf20, 2.1.0+46672772b4, 2.1.0+6e4932cda8, 2.1.0+7d1a95b046, 2.1.0+9820899b38, 2.1.0+9e3e10c5ed, 2.1.0+bcad9dabe1, 2.1.0+e6216047b8, 2.1.0+e650d3708b, 2.2.0+e28a256d71, 3.0.0+45fff310c8, 3.0.0+757b6a61e7, 3.0.0+901819d2b6, 3.0.0+989adb9a29, 3.0.0+a9bc1a3647, 3.0.0+dedb7bdf33, 3.1.0+5fe38ffd73, 3.1.0+cf34004b8a, 3.2.0+git35c6c7c6)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

williamwen42 added a commit that referenced this pull request Nov 25, 2024
@williamwen42
handle sympy.oo in bitwise_and/or value_ranges
5490cd4 
ghstack-source-id: e1e7d5f
Pull Request resolved: #141522
@williamwen42 williamwen42 requested a review from ezyang November 25, 2024 21:52
@ezyang
Copy link
Contributor

ezyang commented Nov 26, 2024

This is probably one of those cases where inductor is yolo'ing a -sympy.oo, sympy.oo range for an integral value

@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 26, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@williamwen42
Copy link
Member Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
handle sympy.oo in bitwise_and/or value_ranges (pytorch#141522)
fa89a5f 
An internal test is failing due to not handling `sympy.oo` properly in bitwise_and/or value_ranges: [T208684142](https://www.internalfb.com/intern/tasks/?t=208684142). I don't know how to repro this - seems like this requires inductor to trigger as well.

Pull Request resolved: pytorch#141522
Approved by: https://github.com/ezyang
ghstack dependencies: pytorch#138777
ezyang added a commit that referenced this pull request Dec 11, 2024
@ezyang
Revert "handle sympy.oo in bitwise_and/or value_ranges (#141522)" and…
8702562 
… "[dynamo] add SymNode bitwise and/or (#138777)"

This reverts commit 6fa4356.

This reverts commit ee7eaad.

ghstack-source-id: 7713b8f
Pull Request resolved: #142842
@github-actions github-actions bot deleted the gh/williamwen42/169/head branch December 27, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamic shapes release notes: fx release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@williamwen42 @ezyang @pytorchmergebot