PyProcessGroup: support rank, world size, group name/desc overrides #141529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
oncall: distributed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141529
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 29493da with merge base ad37afd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
fegin
approved these changes
Nov 26, 2024
test/distributed/test_c10d_common.py
Outdated
| if hasattr(self, "file_name"): | ||
| try: | ||
| os.remove(self.file_name) | ||
| except OSError: |
There was a problem hiding this comment.
nit, may be just use EAFP, except (OSError, AttributeError): and remove if?
There was a problem hiding this comment.
done -- didn't even think of that :)
| return True | ||
|
|
||
|
|
||
| class TestPyProcessGroup(TestCase): |
There was a problem hiding this comment.
Directly inheriting from unittest.TestCase seems to cause CI errors.
d4l3k
force-pushed
the
d4l3k/pypg_attrs
branch
from
d2e3b62 to
29493da
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
…ytorch#141529) This improves `PyProcessGroup` so you can override rank, world size and group name/desc methods from Python. These will be needed to support resizable process groups in torchft. This also has some small fixes in test_c10d_pypg.py to use threads instead of processes which speeds up the test execution by ~10x. Test plan: ``` pytest test/distributed/test_c10d_pypg.py ``` Pull Request resolved: pytorch#141529 Approved by: https://github.com/fegin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves
PyProcessGroupso you can override rank, world size and group name/desc methods from Python. These will be needed to support resizable process groups in torchft.This also has some small fixes in test_c10d_pypg.py to use threads instead of processes which speeds up the test execution by ~10x.
Test plan:
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @c-p-i-o