KEMBAR78
Use cuda 12.6 wheels with Manylinux 2.28. Use Manylinux2014 for CPU, CUDA11.8, CUDA12.4 by atalman · Pull Request #141565 · pytorch/pytorch · GitHub
Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Nov 26, 2024

For release 2.6 we will be using only CUDA 12.6 binaries on Manylinux 2.28.
Issue: #123649

@atalman atalman requested a review from a team as a code owner November 26, 2024 13:13
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141565

Note: Links to docs will display an error until the docs builds have been completed.

❌ 18 New Failures

As of commit 0dcd8bd with merge base 4742080 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 26, 2024
@atalman atalman changed the title Use cuda 12.6 wheels with Manylinux 2.28 only Use cuda 12.6 wheels with Manylinux 2.28. Use Manylinux2014 for CPU, CUDA11.8, CUDA12.4 Nov 26, 2024
# favor of GPU_ARCH_VERSION
DESIRED_CUDA: cpu
GPU_ARCH_TYPE: cpu
DOCKER_IMAGE: pytorch/manylinux2_28-builder:cpu-main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe docker images are not used for MacOS builds. TODO: Refactor code to remove this parameter since its confusing.

@atalman atalman added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Nov 26, 2024
@atalman
Copy link
Contributor Author

atalman commented Nov 26, 2024

@pytorchmergebot merge -f "All required builds are passing and lint as well"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

HDCharles added a commit to pytorch/ao that referenced this pull request Nov 27, 2024
pytorch/test-infra#5986 and pytorch/pytorch#141565 changed back to manylinux 2014 for versions of cuda/cpu, testing that this fixes the issue since hte actual error seems to be occuring in the Build the wheel step before hte post script gets run:

https://github.com/pytorch/ao/actions/runs/12041427944/job/33573281510
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
…CUDA11.8, CUDA12.4 (pytorch#141565)

For release 2.6 we will be using only CUDA 12.6 binaries on Manylinux 2.28.
Issue: pytorch#123649
Pull Request resolved: pytorch#141565
Approved by: https://github.com/Skylion007, https://github.com/huydhn, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants