debug handler maintain through decomposition #141612

Gasoonjia · 2024-11-26T21:57:27Z

Stack from ghstack (oldest at bottom):

-> debug handler maintain through decomposition #141612

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition

Differential Revision: D66517480

BC-breaking note

`torch.ao.quantization.pt2e.graph_utils.get_control_flow_submodules` is No Longer a Public API

We aim to make all functions under torch.ao.quantization.pt2e.graph_utils private. This update marks get_control_flow_submodules as a private API.

Currently, only bfs_trace_with_node_process remains public, but it will be marked private in the next release.

BC-breaking note

`torch.ao.quantization.pt2e.graph_utils.get_control_flow_submodules` is No Longer a Public API

We aim to make all functions under torch.ao.quantization.pt2e.graph_utils private. This update marks get_control_flow_submodules as a private API. If you have to or want to continue using get_control_flow_submodules, please make a private call by using _get_control_flow_submodules.

Currently, only bfs_trace_with_node_process remains public, but it will be marked private in the next release.

Example:
Version 2.6:

>>> from torch.ao.quantization.pt2e.graph_utils import get_control_flow_submodules

Version 2.7:

>>> from torch.ao.quantization.pt2e.graph_utils import get_control_flow_submodules
ImportError: cannot import name 'get_control_flow_submodules' from 'torch.ao.quantization.pt2e.graph_utils'
>>> from torch.ao.quantization.pt2e.graph_utils import _get_control_flow_submodules # Note: Use _get_control_flow_submodules for private access

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

pytorch-bot · 2024-11-26T21:57:30Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141612

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 639e389 with merge base 47a571e ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-11-26T21:57:41Z

This pull request was exported from Phabricator. Differential Revision: D66517480

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

facebook-github-bot · 2024-11-26T23:44:37Z

This pull request was exported from Phabricator. Differential Revision: D66517480

Gasoonjia · 2024-11-27T00:07:00Z

#suppress-bc-linter

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

facebook-github-bot · 2024-11-27T00:20:39Z

This pull request was exported from Phabricator. Differential Revision: D66517480

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

Pull Request resolved: #141612 Add checks in the ao numberic debugger to guard the debug handle consistency during aten op decomposition ghstack-source-id: 255582376 Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/)

facebook-github-bot · 2024-11-27T00:46:50Z

This pull request was exported from Phabricator. Differential Revision: D66517480

test/quantization/pt2e/test_numeric_debugger.py

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

facebook-github-bot · 2024-12-10T09:30:07Z

This pull request was exported from Phabricator. Differential Revision: D66517480

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

facebook-github-bot · 2024-12-10T09:45:50Z

This pull request was exported from Phabricator. Differential Revision: D66517480

albanD · 2024-12-10T19:47:11Z

docs/source/conf.py

    "node_arg_is_weight",
    "return_arg_list",
    # torch.ao.quantization.pt2e.graph_utils
+    "bfs_trace_with_node_process",


Adding new entries in this file is not ok.
Please make sure that all the new public APIs that you add are properly documented and show up on the website.

Thanks for the feedback. Any example I can use for documentation? I noticed that all public APIs under torch.ao.quantization.pt2e.graph_utils are in this file and (looks like) there's not any doc for graph_utils.

If allowed, we can first add bfs_trace_with_node_process here, and have another PR for all doc stuff under graph_utils.

graph_utils shouldn't be public API, I'd recommend to make this private (add _)

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

facebook-github-bot · 2024-12-10T23:30:47Z

This pull request was exported from Phabricator. Differential Revision: D66517480

Pull Request resolved: #141612 Add checks in the ao numberic debugger to guard the debug handle consistency during aten op decomposition ghstack-source-id: 257550559 Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/)

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

facebook-github-bot · 2024-12-11T23:06:05Z

This pull request was exported from Phabricator. Differential Revision: D66517480

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

Pull Request resolved: #141612 Add checks in the ao numberic debugger to guard the debug handle consistency during aten op decomposition ghstack-source-id: 257747832 Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/)

facebook-github-bot · 2024-12-12T02:32:56Z

This pull request was exported from Phabricator. Differential Revision: D66517480

facebook-github-bot · 2024-12-12T12:19:16Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2024-12-12T12:21:09Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

debug handler maintain through decomposition

d9bcc81

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

Gasoonjia requested a review from jerryzh168 as a code owner November 26, 2024 21:57

pytorch-bot bot added the release notes: quantization release notes category label Nov 26, 2024

Gasoonjia mentioned this pull request Nov 26, 2024

support condition branch in ao debug handler #141516

Closed

facebook-github-bot added the fb-exported label Nov 26, 2024

Update on "debug handler maintain through decomposition"

4b119b1

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

Update on "debug handler maintain through decomposition"

cec1f91

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

Update on "debug handler maintain through decomposition"

78e1cf2

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

Gasoonjia added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Nov 27, 2024

jerryzh168 reviewed Dec 10, 2024

View reviewed changes

test/quantization/pt2e/test_numeric_debugger.py Show resolved Hide resolved

jerryzh168 approved these changes Dec 10, 2024

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 10, 2024

Update on "debug handler maintain through decomposition"

0066753

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

Gasoonjia requested a review from albanD as a code owner December 10, 2024 09:29

Update on "debug handler maintain through decomposition"

8a2477b

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

albanD requested changes Dec 10, 2024

View reviewed changes

Update on "debug handler maintain through decomposition"

32e3b7b

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

Update on "debug handler maintain through decomposition"

980afc8

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

Update on "debug handler maintain through decomposition"

639e389

Add checks in the ao numberic debugger to guard the debug handle consistency between aten op decomposition Differential Revision: [D66517480](https://our.internmc.facebook.com/intern/diff/D66517480/) [ghstack-poisoned]

pytorchmergebot added the merging label Dec 12, 2024

pytorchmergebot closed this in 9126110 Dec 12, 2024

pytorchmergebot added Merged and removed merging labels Dec 12, 2024

github-actions bot deleted the gh/Gasoonjia/3/head branch January 14, 2025 02:03

debug handler maintain through decomposition #141612

debug handler maintain through decomposition #141612

Uh oh!

Conversation

Gasoonjia commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BC-breaking note

torch.ao.quantization.pt2e.graph_utils.get_control_flow_submodules is No Longer a Public API

BC-breaking note

torch.ao.quantization.pt2e.graph_utils.get_control_flow_submodules is No Longer a Public API

Uh oh!

pytorch-bot bot commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141612

✅ No Failures

Uh oh!

facebook-github-bot commented Nov 26, 2024

Uh oh!

facebook-github-bot commented Nov 26, 2024

Uh oh!

Gasoonjia commented Nov 27, 2024

Uh oh!

facebook-github-bot commented Nov 27, 2024

Uh oh!

facebook-github-bot commented Nov 27, 2024

Uh oh!

Uh oh!

facebook-github-bot commented Dec 10, 2024

Uh oh!

facebook-github-bot commented Dec 10, 2024

Uh oh!

albanD Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

Gasoonjia Dec 11, 2024

Choose a reason for hiding this comment

Uh oh!

Gasoonjia Dec 11, 2024

Choose a reason for hiding this comment

Uh oh!

jerryzh168 Dec 13, 2024

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Dec 10, 2024

Uh oh!

facebook-github-bot commented Dec 11, 2024

Uh oh!

facebook-github-bot commented Dec 12, 2024

Uh oh!

facebook-github-bot commented Dec 12, 2024

Uh oh!

pytorchmergebot commented Dec 12, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Gasoonjia commented Nov 26, 2024 •

edited

Loading

`torch.ao.quantization.pt2e.graph_utils.get_control_flow_submodules` is No Longer a Public API

`torch.ao.quantization.pt2e.graph_utils.get_control_flow_submodules` is No Longer a Public API

pytorch-bot bot commented Nov 26, 2024 •

edited

Loading