Clarify torch.arange floating-point rounding behavior #141655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141655
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d2e6730 with merge base 9b89fa4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: python_frontend
|
Hi @cpuhrsch, could you take a look at these changes, please |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Added documentation note clarifying the rounding behavior of `torch.arange` when using floating-point dtypes, particularly for reduced precision types like `bfloat16`. This helps users understand potential issues like repeated values and provides guidance on using integer dtypes for precise sequences. ## Changes - Added explanatory note about floating-point rounding behavior and its effects - Included specific mention of `bfloat16` dtype issues - Added recommendation to use integer dtypes for precise sequences Fixes [pytorch#137774](pytorch#137774) Pull Request resolved: pytorch#141655 Approved by: https://github.com/cpuhrsch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation note clarifying the rounding behavior of
torch.arangewhen using floating-point dtypes, particularly for reduced precision types likebfloat16. This helps users understand potential issues like repeated values and provides guidance on using integer dtypes for precise sequences.Changes
bfloat16dtype issuesFixes #137774