KEMBAR78
[MPS] Add autocast rule for SDPA by hvaara · Pull Request #141776 · pytorch/pytorch · GitHub
Skip to content

[MPS] Add autocast rule for SDPA #141776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[MPS] Add autocast rule for SDPA #141776

wants to merge 5 commits into from

Conversation

@hvaara
Copy link
Contributor

@hvaara hvaara commented Nov 28, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141776

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 6a53b03 with merge base 45ed7c1 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@hvaara hvaara mentioned this pull request Nov 28, 2024
Closed
@hvaara
Copy link
Contributor Author

hvaara commented Nov 28, 2024

@pytorchbot label "release notes: mps"

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Nov 28, 2024
@Skylion007 Skylion007 added the ciflow/mps Run MPS tests (subset of trunk) label Nov 28, 2024
malfet
malfet approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix and test

@malfet malfet added the topic: bug fixes topic category label Nov 29, 2024
malfet
malfet reviewed Nov 29, 2024
View reviewed changes
@malfet
Copy link
Contributor

malfet commented Nov 29, 2024

@pytorchbot merge -f "Lint + MPS are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@hvaara hvaara deleted the sdpa-autocast branch November 30, 2024 23:48
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@hvaara @malfet
[MPS] Add autocast rule for SDPA (pytorch#141776)
b1952b7 
Fixes pytorch#141774

Pull Request resolved: pytorch#141776
Approved by: https://github.com/malfet

Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged module: amp (automated mixed precision) autocast open source release notes: mps Release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MPS] Autocast fails for F.scaled_dot_product_attention

5 participants

@hvaara @malfet @pytorchmergebot @Skylion007 @pytorchbot