KEMBAR78
fix c10::Event UT failure on XPU backend by guangyey · Pull Request #141800 · pytorch/pytorch · GitHub
Skip to content

fix c10::Event UT failure on XPU backend #141800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

fix c10::Event UT failure on XPU backend #141800

wants to merge 4 commits into from

Conversation

@guangyey
Copy link
Collaborator

@guangyey guangyey commented Nov 29, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Motivation

Fix this UT failure introduced by #140865. The unrelated failure suppressed this UT failure.
It goes to happen since #141546 is landed.

cc @gujinghui @EikanWang @fengyuan14

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 29, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141800

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 0bd474d with merge base 5deca07 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 29, 2024
guangyey added a commit that referenced this pull request Nov 29, 2024
@guangyey
fix c10::Event UT on XPU backend
718d960 
ghstack-source-id: 59edbe5
Pull Request resolved: #141800
@guangyey guangyey added ciflow/xpu Run XPU CI tasks module: xpu Intel XPU related issues labels Nov 29, 2024
@guangyey guangyey added this to the 2.6.0 milestone Nov 29, 2024
@guangyey guangyey changed the title fix c10::Event UT on XPU backend fix c10::Event UT failure on XPU backend Nov 29, 2024
@guangyey guangyey added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 29, 2024
EikanWang
EikanWang requested changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@EikanWang EikanWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls. fix the failure

@guangyey
Update
fc0c35e 
[ghstack-poisoned]
guangyey added a commit that referenced this pull request Nov 30, 2024
@guangyey
fix c10::Event UT on XPU backend
75cb232 
ghstack-source-id: 4687fd7
Pull Request resolved: #141800
@guangyey guangyey requested a review from EikanWang November 30, 2024 02:58
@guangyey
Update
1ac352e 
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

guangyey commented Dec 2, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/guangyey/104/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/141800)

pytorchmergebot pushed a commit that referenced this pull request Dec 2, 2024
@guangyey
fix c10::Event UT on XPU backend
0a1e595 
ghstack-source-id: d01702d
Pull Request resolved: #141800
@guangyey
Update
98c745f 
[ghstack-poisoned]
@guangyey
Update
0bd474d 
[ghstack-poisoned]
@guangyey
Copy link
Collaborator Author

guangyey commented Dec 3, 2024

"Unrelated failures, we have an issue #141861 to track this failure"
@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 3, 4, linux.idc.xpu), xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 4, 4, linux.idc.xpu), trunk / win-vs2019-cpu-py3 / test (default, 1, 3, lf.windows.4xlarge.nonephemeral, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@guangyey
fix c10::Event UT failure on XPU backend (pytorch#141800)
a91a006 
# Motivation
Fix this UT failure introduced by pytorch#140865. The unrelated failure suppressed this UT failure.
It goes to happen since pytorch#141546 is landed.

Pull Request resolved: pytorch#141800
Approved by: https://github.com/EikanWang
@github-actions github-actions bot deleted the gh/guangyey/104/head branch January 2, 2025 02:05
@atalman atalman mentioned this pull request Jan 13, 2025
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EikanWang EikanWang EikanWang approved these changes

@gujinghui gujinghui Awaiting requested review from gujinghui

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: xpu Intel XPU related issues open source topic: not user facing topic category

Projects

PyTorch Intel
Status: Done

Milestone

2.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@guangyey @pytorchmergebot @EikanWang @pytorchbot