[REFACTOR] Factor _fx_graph_cache_key and _time_taken_ns to common base class #141878
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141878
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 9e410a3 with merge base a34a56f ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
SherlockNoMad,
albanD,
antoniojkim,
bdhirsh and
miladm
| # TODO: Remove underscores here | ||
|
|
||
| # None if the output is not remote cacheable | ||
| _fx_graph_cache_key: Optional[str] = dataclasses.field(default=None, init=False) |
There was a problem hiding this comment.
Do we think this should be a method instead? And then have each implementation decide how to implement the method?
There was a problem hiding this comment.
I am still trying to understand how this field is populated, but my current impression is that we bong these attributes in no matter what concrete OutputCode subclass we have, so no, having it be a property under this design is probably fine.
ezyang
added
ciflow/trunk
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…se class (pytorch#141878) Signed-off-by: Edward Z. Yang <ezyang@meta.com> Pull Request resolved: pytorch#141878 Approved by: https://github.com/jamesjwu ghstack dependencies: pytorch#141877
3 participants
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@meta.com
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov