KEMBAR78
[submodule] Revert "Adds support for accelerated sorting with x86-simd-sort (#127936) by atalman · Pull Request #141901 · pytorch/pytorch · GitHub
Skip to content

[submodule] Revert "Adds support for accelerated sorting with x86-simd-sort (#127936) #141901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[submodule] Revert "Adds support for accelerated sorting with x86-simd-sort (#127936) #141901

wants to merge 1 commit into from

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Dec 2, 2024 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141901

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 4980dcf with merge base fe68f61 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor labels Dec 2, 2024
@atalman atalman mentioned this pull request Dec 2, 2024
Closed
@atalman atalman changed the title Revert "Adds support for accelerated sorting with x86-simd-sort (#127… Revert "Adds support for accelerated sorting with x86-simd-sort (#127936) Dec 2, 2024
@atalman atalman added the topic: not user facing topic category label Dec 2, 2024
@atalman
Copy link
Contributor Author

atalman commented Dec 2, 2024

@pytorchmergebot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 2, 2024
@pytorchmergebot
Copy link
Collaborator

This PR updates submodules third_party/x86-simd-sort

If those updates are intentional, please add "submodule" keyword to PR title/description.

@atalman atalman changed the title Revert "Adds support for accelerated sorting with x86-simd-sort (#127936) [submodule] Revert "Adds support for accelerated sorting with x86-simd-sort (#127936) Dec 2, 2024
@atalman
Copy link
Contributor Author

atalman commented Dec 3, 2024

@pytorchmergebot merge -f "required jobs are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@atalman
[submodule] Revert "Adds support for accelerated sorting with x86-sim…
19c8395 
…d-sort (pytorch#127936) (pytorch#141901)

Looks like the original PR caused: pytorch#140590

Please see comment: pytorch#140590 (comment)

Pull Request resolved: pytorch#141901
Approved by: https://github.com/andrewor14, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewor14 andrewor14 andrewor14 approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atalman @pytorchmergebot @andrewor14 @malfet