[pipelining] Improve schedule csv loading #142009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pytorch-bot
bot
added
the
oncall: distributed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142009
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit e2b470c with merge base 5deca07 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
H-Huang
added
module: pipelining
lessw2020
approved these changes
Dec 3, 2024
Add small changes based on feedback from Less when testing out pytorch/torchtitan#707 - expose `validate_schedule` as a function - handle spaces around actions in csv file - add error arrow to `_format_pipeline_schedule()` to better show where the step errored cc awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
Add small changes based on feedback from Less when testing out pytorch/torchtitan#707 - expose `validate_schedule` as a function - handle spaces around actions in csv file - add error arrow to `_format_pipeline_schedule()` to better show where the step errored Pull Request resolved: pytorch#142009 Approved by: https://github.com/lessw2020
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 6, 2024
#142009 broke CSV loading since it can no longer handle schedules with `I` and `W`. This was caught in the torchtitan tests which loads a custom CSV file using `I` and `W` https://github.com/pytorch/torchtitan/actions/runs/12188167461/job/34000683921?pr=689. Follow up would be to test a real custom schedule in PyTorch rather than torchtitan. The custom schedule in titan is here: https://github.com/pytorch/torchtitan/blob/main/test/assets/custom_schedule.csv Pull Request resolved: #142211 Approved by: https://github.com/mori360 ghstack dependencies: #142009
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
Add small changes based on feedback from Less when testing out pytorch/torchtitan#707 - expose `validate_schedule` as a function - handle spaces around actions in csv file - add error arrow to `_format_pipeline_schedule()` to better show where the step errored Pull Request resolved: pytorch#142009 Approved by: https://github.com/lessw2020
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
#142009 broke CSV loading since it can no longer handle schedules with `I` and `W`. This was caught in the torchtitan tests which loads a custom CSV file using `I` and `W` https://github.com/pytorch/torchtitan/actions/runs/12188167461/job/34000683921?pr=689. Follow up would be to test a real custom schedule in PyTorch rather than torchtitan. The custom schedule in titan is here: https://github.com/pytorch/torchtitan/blob/main/test/assets/custom_schedule.csv Pull Request resolved: #142211 Approved by: https://github.com/mori360 ghstack dependencies: #142009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add small changes based on feedback from Less when testing out pytorch/torchtitan#707
validate_scheduleas a function_format_pipeline_schedule()to better show where the step erroredcc @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o