fix linalg.SVD docs typo: wrong V* shape in reduced SVD #142037
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://en.wikipedia.org/wiki/Singular_value_decomposition#Reduced_SVDs in reduced SVD V* shape is (n, k) V shape is (n, k) in docs it was wrong
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142037
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5358994 with merge base d648133 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The committers listed above are authorized under a signed CLA. |
lezcano
approved these changes
Dec 4, 2024
|
@pytorchbot merge -f "docs fix" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
https://en.wikipedia.org/wiki/Singular_value_decomposition#Reduced_SVDs in reduced SVD V* shape is (n, k) V shape is (n, k) in docs it was wrong Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#142037 Approved by: https://github.com/lezcano
AmdSampsa
pushed a commit
to AmdSampsa/pytorch
that referenced
this pull request
Dec 9, 2024
https://en.wikipedia.org/wiki/Singular_value_decomposition#Reduced_SVDs in reduced SVD V* shape is (n, k) V shape is (n, k) in docs it was wrong Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#142037 Approved by: https://github.com/lezcano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://en.wikipedia.org/wiki/Singular_value_decomposition#Reduced_SVDs
in reduced SVD
V* shape is (n, k)
V shape is (n, k)
in docs it was wrong
Fixes #ISSUE_NUMBER