Use cxx11-abi for Linux CUDA 12.6 builds #142064
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142064
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 4 Cancelled Jobs, 1 Unrelated FailureAs of commit c9a3177 with merge base 51b7528 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
approved these changes
Dec 4, 2024
atalman
added
the
ciflow/binaries
malfet
approved these changes
Dec 4, 2024
| "use_split_build": "True" if use_split_build else "False", | ||
| "devtoolset": ( | ||
| "cxx11-abi" if arch_version == "cuda-aarch64" else "" | ||
| "cxx11-abi" if (arch_version == "cuda-aarch64" or arch_version == "12.6") else "" |
There was a problem hiding this comment.
Why do it cuda-aarch64 build, but not for CPU ones?
Suggested change
| "cxx11-abi" if (arch_version == "cuda-aarch64" or arch_version == "12.6") else "" | |
| "cxx11-abi" if ("aarch64" in arch_version or arch_version == "12.6") else "" |
There was a problem hiding this comment.
Yes totally, this is already done. CPU arch already added here: https://github.com/pytorch/pytorch/pull/142064/files/f9843ea946249a34fcf3abb08924bb38118c0432#diff-c629948d2bb1c874955838190a9cd19f154709c0a36e071e5da91abb457d9b05R426
Line 424:
"devtoolset": (
"cxx11-abi"
if (arch_version in ["cpu-cxx11-abi", "cpu-aarch64"])
or gpu_arch_type == "rocm"
else ""
),
There was a problem hiding this comment.
This script will need some refactoring as BE, it because a little hard to read.
|
@pytorchmergebot merge -f "all required jobs are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Manylinux 2.28 and cxx11-abi migration. Please see: https://dev-discuss.pytorch.org/t/pytorch-linux-wheels-switching-to-new-wheel-build-platform-manylinux-2-28-on-november-12-2024/2581 Pull Request resolved: #142064 Approved by: https://github.com/kit1980, https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manylinux 2.28 and cxx11-abi migration. Please see: https://dev-discuss.pytorch.org/t/pytorch-linux-wheels-switching-to-new-wheel-build-platform-manylinux-2-28-on-november-12-2024/2581