KEMBAR78
Migrate windows build scripts from builder to pytorch by atalman · Pull Request #142156 · pytorch/pytorch · GitHub
Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Dec 5, 2024

Move builder windows build scripts to pytorch/pytorch
Remove builder checkout during windows build
Pending remove windows build scripts https://github.com/pytorch/builder/tree/main/windows

cc @albanD

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142156

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 62aec97 with merge base a5ec09d (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Dec 5, 2024
@atalman atalman added ciflow/binaries Trigger all binary build and upload jobs on the PR and removed release notes: releng release notes category labels Dec 5, 2024
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Dec 5, 2024
@atalman atalman marked this pull request as ready for review December 5, 2024 21:40
@atalman atalman requested a review from a team as a code owner December 5, 2024 21:40
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please post a corresponding PR that deletes those from builder repo. And also, specify commit hash those files are coming from

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for chimerical-cranachan-793287 ready!

Name Link
🔨 Latest commit c735507
🔍 Latest deploy log https://app.netlify.com/sites/chimerical-cranachan-793287/deploys/6753468750f40700089cd33d
😎 Deploy Preview https://deploy-preview-142156--chimerical-cranachan-793287.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@chuanqi129 chuanqi129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks to migrate it into pytorch repo. For xpu installation bat script, I think the xpu Windows ci can use the same script with cd, how do you think it? I can submit a PR to do it after this PR land.

@atalman
Copy link
Contributor Author

atalman commented Dec 8, 2024

@pytorchmergebot merge -f "All required jobs are passing"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
Move builder windows build scripts to pytorch/pytorch
Remove builder checkout during windows build
Pending remove windows build scripts https://github.com/pytorch/builder/tree/main/windows

Pull Request resolved: pytorch#142156
Approved by: https://github.com/malfet, https://github.com/chuanqi129
pytorchmergebot pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR Merged release notes: releng release notes category skip-pr-sanity-checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants