-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Migrate windows build scripts from builder to pytorch #142156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142156
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Unrelated FailureAs of commit 62aec97 with merge base a5ec09d ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please post a corresponding PR that deletes those from builder repo. And also, specify commit hash those files are coming from
✅ Deploy Preview for chimerical-cranachan-793287 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks to migrate it into pytorch repo. For xpu installation bat script, I think the xpu Windows ci can use the same script with cd, how do you think it? I can submit a PR to do it after this PR land.
|
@pytorchmergebot merge -f "All required jobs are passing" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Move builder windows build scripts to pytorch/pytorch Remove builder checkout during windows build Pending remove windows build scripts https://github.com/pytorch/builder/tree/main/windows Pull Request resolved: pytorch#142156 Approved by: https://github.com/malfet, https://github.com/chuanqi129
Follow #142156 Works for #114850 Pull Request resolved: #143185 Approved by: https://github.com/atalman
Move builder windows build scripts to pytorch/pytorch
Remove builder checkout during windows build
Pending remove windows build scripts https://github.com/pytorch/builder/tree/main/windows
cc @albanD