KEMBAR78
[EZ] Remove unused binary_linux_build.sh by malfet · Pull Request #142276 · pytorch/pytorch · GitHub
Skip to content

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Dec 6, 2024

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 6, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142276

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 5e5d508 with merge base 6e203ae (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Dec 6, 2024
@malfet malfet requested a review from a team December 7, 2024 00:01
@malfet
Copy link
Contributor Author

malfet commented Dec 7, 2024

@pytorchbot merge -f "All builds except for S390 have started successfully"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
pytorchmergebot pushed a commit that referenced this pull request Dec 9, 2024
Added https://github.com/pytorch/builder/blob/c7564f31f7e1e5c8fab2f4ce511b2d73a3afbe60/wheel/build_wheel.sh to `.ci/wheel/` folder

Commented out call to https://github.com/pytorch/builder/blob/39532891a083f0929d3b46f690a3ea719de6bf76/run_tests.sh, because since 2018 this script just checked that tests folder is there and exited, as there are no way to run all pytorch tests in single shard, see this logic:
```bash
#!/bin/bash
set -eux -o pipefail

# Essentially runs pytorch/test/run_test.py, but keeps track of which tests to
# skip in a centralized place.
#
# TODO Except for a few tests, this entire file is a giant TODO. Why are these
# tests # failing?
# TODO deal with Windows

# This script expects to be in the pytorch root folder
if [[ ! -d 'test' || ! -f 'test/run_test.py' ]]; then
    echo "builder/test.sh expects to be run from the Pytorch root directory " \
         "but I'm actually in $(pwd)"
    exit 2
fi

# Allow master skip of all tests
if [[ -n "${SKIP_ALL_TESTS:-}" ]]; then
    exit 0
fi
```

#123390 is a misread attempt to interpret above-mentioned logic, as run_tests will be skipped if `${SKIP_ALL_TESTS}` is a non-empty string
Pull Request resolved: #142277
Approved by: https://github.com/huydhn, https://github.com/atalman
ghstack dependencies: #142276
pytorchmergebot pushed a commit that referenced this pull request Dec 9, 2024
According to https://github.com/search?type=code&q=binary_macos_test.sh+repo%3Apytorch%2Fpytorch (and grep in the repo) it's not used anywhere

Pull Request resolved: #142382
Approved by: https://github.com/atalman
ghstack dependencies: #142276, #142277
pytorchmergebot pushed a commit that referenced this pull request Dec 9, 2024
All logic should have been migrated to .ci/manywheel folder from builder repo a while back
Pull Request resolved: #142282
Approved by: https://github.com/atalman
ghstack dependencies: #142276, #142277, #142382
@github-actions github-actions bot deleted the gh/malfet/76/head branch January 7, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants