KEMBAR78
[CI] Add xpu new docker image name into docker builds workflow by chuanqi129 · Pull Request #142298 · pytorch/pytorch · GitHub
Skip to content

[CI] Add xpu new docker image name into docker builds workflow #142298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CI] Add xpu new docker image name into docker builds workflow #142298

wants to merge 1 commit into from

Conversation

@chuanqi129
Copy link
Collaborator

@chuanqi129 chuanqi129 commented Dec 7, 2024 •
edited
Loading

Add missed new xpu docker image name to adapt the new mechanism introduced by pytorch/test-infra#6013
Works for #114850

@chuanqi129 chuanqi129 requested a review from a team as a code owner December 7, 2024 07:45
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 7, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142298

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4728eb8 with merge base 8cb68b1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@chuanqi129 chuanqi129 requested review from atalman and huydhn December 7, 2024 07:45
huydhn
huydhn approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Let me follow up with an action item to write a linter check for this

@huydhn
Copy link
Contributor

huydhn commented Dec 7, 2024

Adding a new Docker image here requires adding a new AWS ECR entry. This step is done manually once, so feel free to ping me in the future of you need to create one. You will see error like https://github.com/pytorch/pytorch/actions/runs/12211155425/job/34068063985#step:6:11896 otherwise

@huydhn huydhn mentioned this pull request Dec 7, 2024
Merged
@huydhn
Copy link
Contributor

huydhn commented Dec 7, 2024

@pytorchbot drci

@huydhn
Copy link
Contributor

huydhn commented Dec 7, 2024

The other Docker failure https://github.com/pytorch/pytorch/actions/runs/12211155425/job/34068684590 isn't related to your change but it's triggered by it as all images are rebuilt, so let me take a look

@chuanqi129
Copy link
Collaborator Author

Thanks @huydhn for the review and help! The xpu docker images can pass now.

@etaf etaf added ciflow/xpu Run XPU CI tasks and removed ciflow/xpu Run XPU CI tasks labels Dec 8, 2024
@etaf
Copy link
Collaborator

etaf commented Dec 8, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xpu_workflow_fix onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout xpu_workflow_fix && git pull --rebase)

@etaf
Copy link
Collaborator

etaf commented Dec 8, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 8, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@chuanqi129 chuanqi129 mentioned this pull request Dec 9, 2024
Closed
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@chuanqi129 @AmdSampsa
[CI] Add xpu new docker image name into docker builds workflow (#142298)
2fcacfe 
Add missed new xpu docker image name to adapt the new mechanism introduced by pytorch/test-infra#6013
Works for #114850
Pull Request resolved: #142298
Approved by: https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chuanqi129 @huydhn @etaf @pytorchmergebot @pytorchbot