[Inductor] Generalize newly introduced device-bias code to align the behavior of XPU unroll reduction with cuda. #142348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142348
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 4660cc8 with merge base f14ce3a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
etaf
changed the title
This was referenced Dec 9, 2024
Closed
etaf
changed the title
etaf
changed the title
|
The failed job xpu / linux-jammy-xpu-2025.0-py3.9 / test (default, 1, 4, linux.idc.xpu) (gh) |
desertfire
approved these changes
Dec 9, 2024
jansel
approved these changes
Dec 9, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
This pull request was exported from Phabricator. Differential Revision: D66989028 |
This was referenced Dec 10, 2024
mori360
pushed a commit
to mori360/pytorch
that referenced
this pull request
Dec 11, 2024
…behavior of XPU unroll reduction with cuda. (pytorch#142348) Fix pytorch#141861 Pull Request resolved: pytorch#142348 Approved by: https://github.com/desertfire, https://github.com/jansel
Esquains
pushed a commit
to Esquains/study1
that referenced
this pull request
Dec 15, 2024
…behavior of XPU unroll reduction with cuda. (#142348) Fix #141861 Pull Request resolved: pytorch/pytorch#142348 Approved by: https://github.com/desertfire, https://github.com/jansel Internal: << DO NOT EDIT BELOW THIS LINE >> Differential Revision: [D66989028](https://our.internmc.facebook.com/intern/diff/D66989028/) ghstack-source-id: 257319382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fix #141861
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov