KEMBAR78
[FSDP2] Gate PT2 code for torch deploy by awgu · Pull Request #142456 · pytorch/pytorch · GitHub
Skip to content

[FSDP2] Gate PT2 code for torch deploy #142456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FSDP2] Gate PT2 code for torch deploy #142456

wants to merge 1 commit into from

Conversation

@awgu
Copy link
Collaborator

@awgu awgu commented Dec 10, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

See diff for internal details

cc @H-Huang @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

Differential Revision: D67003832

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 10, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142456

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit f9f2cfa with merge base e4ecb09 (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

awgu pushed a commit that referenced this pull request Dec 10, 2024
[FSDP2] Gate PT2 code for torch deploy
936849d 
ghstack-source-id: 6340e7f
Pull Request resolved: #142456
@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp) release notes category labels Dec 10, 2024
awgu
awgu commented Dec 10, 2024
View reviewed changes
torch/distributed/fsdp/_fully_shard/_fsdp_param.py

torch.fx.node.has_side_effect(torch.ops.fsdp.copy_.default)
if not torch._running_with_deploy():
torch.fx.node.has_side_effect(torch.ops.fsdp.copy_.default)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Exception Caught inside torch::deploy embedded library: 
AttributeError: '_OpNamespace' 'fsdp' object has no attribute 'copy_'

@awgu awgu added release notes: distributed (fsdp2) release notes category and removed release notes: distributed (fsdp) release notes category labels Dec 10, 2024
@awgu
Copy link
Collaborator Author

awgu commented Dec 10, 2024

@awgu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 10, 2024
@awgu awgu requested review from fegin, weifengpy, wz337 and yf225 December 10, 2024 03:32
@awgu
Copy link
Collaborator Author

awgu commented Dec 10, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@awgu
Copy link
Collaborator Author

awgu commented Dec 10, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@awgu awgu mentioned this pull request Dec 11, 2024
Closed
@awgu awgu mentioned this pull request Dec 16, 2024
Closed
@github-actions github-actions bot deleted the gh/awgu/663/head branch January 11, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fegin fegin fegin approved these changes

@yf225 yf225 yf225 approved these changes

@weifengpy weifengpy weifengpy approved these changes

@wz337 wz337 Awaiting requested review from wz337

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (fsdp2) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@awgu @pytorchmergebot @fegin @yf225 @weifengpy