[MPS] Support torch.Event for MPS #142468

guangyey · 2024-12-10T06:31:40Z

Stack from ghstack (oldest at bottom):

Motivation

Support torch.Event on mps backend.

pytorch-bot · 2024-12-10T06:31:44Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142468

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit c8b0153 with merge base 1cb2ebd ():

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

Lint / workflow-checks / linux-job (gh) (#142485)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

guangyey · 2024-12-10T09:45:55Z

@malfet May I know if this PR is reasonable to you?

[ghstack-poisoned]

kulinseth · 2024-12-10T20:09:15Z

Don't we have this support here ?
https://github.com/pytorch/pytorch/blob/main/torch/mps/event.py

kulinseth · 2024-12-10T20:09:29Z

@guangyey can you take a look and see what's missing ?

malfet

Thank you very much for the prompt fix

malfet · 2024-12-10T21:10:33Z

@pytorchbot merge -f "Lint + MPS are green"

pytorchmergebot · 2024-12-10T21:12:01Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-12-10T21:12:08Z

Merge failed

Reason: PR #142468 has not been reviewed yet

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

malfet · 2024-12-10T21:13:18Z

Don't we have this support here ? https://github.com/pytorch/pytorch/blob/main/torch/mps/event.py

This PR is step forward towards the idea of being able to write accelerator agnostic code and replace neverending

event = torch.cuda.Event() if torch.cuda.is_available() else torch.mps.Event() if torch.mps.is_available() else DummyEvent()

with something torch.Event()

malfet · 2024-12-10T21:13:39Z

@pytorchbot merge -f "Lint + MPS are green"

pytorchmergebot · 2024-12-10T21:17:13Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

guangyey · 2024-12-11T01:38:29Z

@guangyey can you take a look and see what's missing ?

As @malfet explained, this PR will support device-agnostic torch.Event("MPS") on the MPS backend. This will make it easier for the user to write device-agnostic code.

# Motivation This PR intends to add UTs for accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in #142468. The previous commit is 952514f Pull Request resolved: #133572 Approved by: https://github.com/EikanWang, https://github.com/albanD ghstack dependencies: #142468

# Motivation This PR intends to add C++ accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in #142468. The previous commit is f84e533 Pull Request resolved: #138677 Approved by: https://github.com/albanD, https://github.com/EikanWang ghstack dependencies: #142468, #133572

kulinseth

Looks good to me.

guangyey · 2024-12-13T05:19:37Z

Looks good to me.

Thanks.

ghstack-source-id: ffe3755 Pull Request resolved: pytorch/pytorch#142468

# Motivation This PR intends to add UTs for accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in #142468. The previous commit is 952514f Pull Request resolved: #133572 Approved by: https://github.com/EikanWang, https://github.com/albanD ghstack dependencies: #143171

…38677) # Motivation This PR intends to add C++ accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in pytorch#142468. The previous commit is pytorch@f84e533 Pull Request resolved: pytorch#138677 Approved by: https://github.com/albanD, https://github.com/EikanWang ghstack dependencies: pytorch#143171, pytorch#133572

…h#133572) # Motivation This PR intends to add UTs for accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in pytorch#142468. The previous commit is pytorch@952514f Pull Request resolved: pytorch#133572 Approved by: https://github.com/EikanWang, https://github.com/albanD ghstack dependencies: pytorch#143171

…38677) # Motivation This PR intends to add C++ accelerator device-agnostic APIs. # Additional Context This PR is relanded. It is reverted because `torch.Event` doesn't support mps backend. We have fixed it in pytorch#142468. The previous commit is pytorch@f84e533 Pull Request resolved: pytorch#138677 Approved by: https://github.com/albanD, https://github.com/EikanWang ghstack dependencies: pytorch#143171, pytorch#133572

guangyey requested review from kulinseth and malfet as code owners December 10, 2024 06:31

pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 10, 2024

This was referenced Dec 10, 2024

[RELAND] Add UTs for accelerator device-agnostic runtime APIs #133572

Closed

[RELAND] Add device-agnostic runtime Device/Stream C++ API #138677

Closed

Support with statement on torch.Stream #140138

Closed

[WIP] Clean up accelerator APIs #137493

Closed

guangyey changed the title ~~[MPS] Support torch.Event for MPS~~ [WIP] [MPS] Support torch.Event for MPS Dec 10, 2024

pytorchbot added the open source label Dec 10, 2024

guangyey added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 10, 2024

guangyey changed the title ~~[WIP] [MPS] Support torch.Event for MPS~~ [MPS] Support torch.Event for MPS Dec 10, 2024

guangyey added 7 commits December 10, 2024 14:10

Update

2bdc10b

[ghstack-poisoned]

Update

e7c83b1

[ghstack-poisoned]

Update

f0a7c5a

[ghstack-poisoned]

Update

0b65532

[ghstack-poisoned]

Update

05db610

[ghstack-poisoned]

Update

00b4598

[ghstack-poisoned]

Update

c8b0153

[ghstack-poisoned]

malfet reviewed Dec 10, 2024

View reviewed changes

malfet added the topic: improvements topic category label Dec 10, 2024

pytorchmergebot added the merging label Dec 10, 2024

pytorchmergebot removed the merging label Dec 10, 2024

malfet approved these changes Dec 10, 2024

View reviewed changes

pytorchmergebot added the merging label Dec 10, 2024

pytorchmergebot added the Merged label Dec 10, 2024

pytorchmergebot closed this in bee445c Dec 10, 2024

pytorchmergebot removed the merging label Dec 10, 2024

kulinseth reviewed Dec 12, 2024

View reviewed changes

Esquains pushed a commit to Esquains/study1 that referenced this pull request Dec 15, 2024

[MPS] Support torch.Event for MPS

a118b59

ghstack-source-id: ffe3755 Pull Request resolved: pytorch/pytorch#142468

github-actions bot deleted the gh/guangyey/106/head branch January 14, 2025 02:02

[MPS] Support torch.Event for MPS #142468

[MPS] Support torch.Event for MPS #142468

Uh oh!

Conversation

guangyey commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Uh oh!

pytorch-bot bot commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142468

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

guangyey commented Dec 10, 2024

Uh oh!

kulinseth commented Dec 10, 2024

Uh oh!

kulinseth commented Dec 10, 2024

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

malfet commented Dec 10, 2024

Uh oh!

pytorchmergebot commented Dec 10, 2024

Merge started

Uh oh!

pytorchmergebot commented Dec 10, 2024

Merge failed

Uh oh!

malfet commented Dec 10, 2024

Uh oh!

malfet commented Dec 10, 2024

Uh oh!

pytorchmergebot commented Dec 10, 2024

Merge started

Uh oh!

guangyey commented Dec 11, 2024

Uh oh!

kulinseth left a comment

Choose a reason for hiding this comment

Uh oh!

guangyey commented Dec 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guangyey commented Dec 10, 2024 •

edited

Loading

pytorch-bot bot commented Dec 10, 2024 •

edited

Loading