[Dynamo] only import einops if version is lower than 0.7.0 #142847

mlazos · 2024-12-11T05:31:06Z

Fixes internal xref (https://fb.workplace.com/groups/257735836456307/posts/804793021750583/?comment_id=805229281706957&reply_comment_id=805232695039949)

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

pytorch-bot · 2024-12-11T05:31:09Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142847

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ecf132a with merge base d547fae ():

NEW FAILURE - The following job has failed:

macos-arm64-binary-wheel / wheel-py3_13-cpu-build (gh)
No files were found with the provided path: /Users/runner/work/_temp/artifacts. No artifacts will be uploaded.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zou3519

sounds good

torch/_dynamo/decorators.py

mlazos · 2024-12-11T23:15:18Z

@pytorchbot merge

pytorchmergebot · 2024-12-11T23:17:22Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-12-12T05:15:58Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

mlazos · 2024-12-12T06:36:07Z

@pytorchbot merge

pytorchmergebot · 2024-12-12T06:37:48Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

atalman · 2024-12-12T18:40:31Z

Seeing an error here:
https://github.com/pytorch/pytorch/actions/runs/12301892273/job/34335593226?pr=143125#step:15:1000

+ python -c 'from smoke_test import test_linalg; test_linalg()'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/pytorch/.ci/pytorch/smoke_test/smoke_test.py", line 11, in <module>
    import torch._dynamo
  File "/opt/python/cp311-cp311/lib/python3.11/site-packages/torch/_dynamo/__init__.py", line 8, in <module>
    from .decorators import (
  File "/opt/python/cp311-cp311/lib/python3.11/site-packages/torch/_dynamo/decorators.py", line 9, in <module>
    from packaging import version
ModuleNotFoundError: No module named 'packaging'

atalman · 2024-12-12T18:42:56Z

@pytorchmergebot revert -c nosignal -m "Breaks binary builds, see the comment above"

atalman · 2024-12-12T18:43:18Z

Please reland this with ciflow/binaries label attached

pytorchmergebot · 2024-12-12T18:44:28Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-12-12T18:44:37Z

@mlazos your PR has been successfully reverted.

…142847)" This reverts commit 357e261. Reverted #142847 on behalf of https://github.com/atalman due to Breaks binary builds, see the comment above ([comment](#142847 (comment)))

mlazos · 2024-12-20T01:01:33Z

@pytorchbot merge

pytorchmergebot · 2024-12-20T01:03:29Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2024-12-20T01:03:48Z

Merge failed

Reason: 1 jobs have failed, first few of them are: macos-arm64-binary-wheel / wheel-py3_13-cpu-build

Details for Dev Infra team

Raised by workflow job

mlazos · 2024-12-20T04:10:36Z

@pytorchbot merge -i

pytorchmergebot · 2024-12-20T04:12:22Z

Merge started

Your change will be merged while ignoring the following 1 checks: macos-arm64-binary-wheel / wheel-py3_13-cpu-build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

If/when einops releases a version greater than 0.8.1, it'll just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. [ghstack-poisoned]

If/when einops releases a version greater than 0.8.1, it might just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - It turns out we didn't need to delete the einops import. We already do not eagerly import einops. - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. [ghstack-poisoned]

If/when einops releases a version greater than 0.8.1, it will just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - It turns out we didn't need to delete the einops import. We already do not eagerly import einops. - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. [ghstack-poisoned]

Fixes #157451 If/when einops releases a version greater than 0.8.1, it will just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - It turns out we didn't need to delete the einops import. We already do not eagerly import einops. - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. [ghstack-poisoned]

Fixes #157451 If/when einops releases a version greater than 0.8.1, it will just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - It turns out we didn't need to delete the einops import. We already do not eagerly import einops. - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. ghstack-source-id: d1dc6e2 Pull Request resolved: #157600

Fixes #157451 If/when einops releases a version greater than 0.8.1, it will just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - It turns out we didn't need to delete the einops import. We already do not eagerly import einops. - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. Pull Request resolved: #157600 Approved by: https://github.com/guilhermeleobas, https://github.com/anijain2305 ghstack dependencies: #157416

Fixes #157451 If/when einops releases a version greater than 0.8.1, it will just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - It turns out we didn't need to delete the einops import. We already do not eagerly import einops. - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. Pull Request resolved: #157600 Approved by: https://github.com/guilhermeleobas, https://github.com/anijain2305 ghstack dependencies: #157416 (cherry picked from commit 5d8d126)

Fix einops x torch.compile interaction (#157600) Fixes #157451 If/when einops releases a version greater than 0.8.1, it will just break (without this patch). The history is: - Between 2.6 and 2.7, we tried to delete the einops import (#142847) - That didn't work so well, so we applied a hotfix in 2.7.1. (#153925) - The hotfix wasn't completely correct (0.8.1 is the latest version of einops, so the condition in the hotfix just always evaluates to True!) - It turns out we didn't need to delete the einops import. We already do not eagerly import einops. - I reverted the code back to the state it was in in 2.6. https://github.com/pytorch/pytorch/blob/release/2.6/torch/_dynamo/decorators.py Test Plan: - We have testing in CI for einops 0.6.1, 0.7.0, and 0.8.1. Wait for CI. Pull Request resolved: #157600 Approved by: https://github.com/guilhermeleobas, https://github.com/anijain2305 ghstack dependencies: #157416 (cherry picked from commit 5d8d126) Co-authored-by: rzou <zou3519@gmail.com>

mlazos requested a review from zou3519 December 11, 2024 05:31

pytorch-bot bot added ciflow/inductor module: dynamo labels Dec 11, 2024

mlazos force-pushed the mlazos/einops-import branch from 29062ff to 72687eb Compare December 11, 2024 05:31

mlazos added the release notes: dynamo label Dec 11, 2024

zou3519 approved these changes Dec 11, 2024

View reviewed changes

torch/_dynamo/decorators.py Outdated Show resolved Hide resolved

torch/_dynamo/decorators.py Outdated Show resolved Hide resolved

mlazos force-pushed the mlazos/einops-import branch 2 times, most recently from 474b862 to f4ccda0 Compare December 11, 2024 23:14

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 11, 2024

pytorchmergebot added the merging label Dec 11, 2024

pytorchmergebot added the Merged label Dec 12, 2024

pytorchmergebot closed this in 357e261 Dec 12, 2024

pytorchmergebot removed the merging label Dec 12, 2024

atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Dec 12, 2024

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Dec 12, 2024

pytorchmergebot reopened this Dec 12, 2024

mlazos force-pushed the mlazos/einops-import branch from 5413749 to ecf132a Compare December 20, 2024 01:01

pytorchmergebot added the merging label Dec 20, 2024

pytorchmergebot removed the merging label Dec 20, 2024

pytorchmergebot added the merging label Dec 20, 2024

pytorchmergebot closed this in 270ad51 Dec 20, 2024

pytorchmergebot removed the merging label Dec 20, 2024

github-actions bot deleted the mlazos/einops-import branch January 20, 2025 02:07

mlazos mentioned this pull request Jun 16, 2025

Stop special-casing einops in Dynamo #142486

Closed

zou3519 mentioned this pull request Jul 4, 2025

Fix einops x torch.compile interaction #157600

Closed

pytorchbot mentioned this pull request Jul 8, 2025

Fix einops x torch.compile interaction #157754

Merged

[Dynamo] only import einops if version is lower than 0.7.0 #142847

[Dynamo] only import einops if version is lower than 0.7.0 #142847

Uh oh!

Conversation

mlazos commented Dec 11, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142847

❌ 1 New Failure

Uh oh!

zou3519 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mlazos commented Dec 11, 2024

Uh oh!

pytorchmergebot commented Dec 11, 2024

Merge started

Uh oh!

pytorchmergebot commented Dec 12, 2024

Uh oh!

mlazos commented Dec 12, 2024

Uh oh!

pytorchmergebot commented Dec 12, 2024

Merge started

Uh oh!

atalman commented Dec 12, 2024

Uh oh!

atalman commented Dec 12, 2024

Uh oh!

atalman commented Dec 12, 2024

Uh oh!

pytorchmergebot commented Dec 12, 2024

Uh oh!

pytorchmergebot commented Dec 12, 2024

Uh oh!

mlazos commented Dec 20, 2024

Uh oh!

pytorchmergebot commented Dec 20, 2024

Merge started

Uh oh!

pytorchmergebot commented Dec 20, 2024

Merge failed

Uh oh!

mlazos commented Dec 20, 2024

Uh oh!

pytorchmergebot commented Dec 20, 2024

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mlazos commented Dec 11, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Dec 11, 2024 •

edited

Loading