-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Remove Checkout pytorch/builder for Linux Binary Builds (#143125) #143131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow Up after: #142282 Remove Checkout pytorch/builder for Linux Binary Builds I believe we where not using builder already. Hence remove this checkout. We should be using scripts from this folder: ``` /pytorch/.ci/${{ inputs.PACKAGE_TYPE }}/build.sh ``` TODO: Will followup with removing BUILDER_ROOT everywhere from PyTorch repo Pull Request resolved: #143125 Approved by: https://github.com/kit1980
atalman
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow Up after: #142282
Remove Checkout pytorch/builder for Linux Binary Builds I believe we where not using builder already. Hence remove this checkout. We should be using scripts from this folder:
TODO: Will followup with removing BUILDER_ROOT everywhere from PyTorch repo
Pull Request resolved: #143125
Approved by: https://github.com/kit1980
Fixes #ISSUE_NUMBER