KEMBAR78
Remove Checkout pytorch/builder for Linux Binary Builds by atalman · Pull Request #143125 · pytorch/pytorch · GitHub
Skip to content

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Dec 12, 2024

Follow Up after: #142282

Remove Checkout pytorch/builder for Linux Binary Builds
I believe we where not using builder already. Hence remove this checkout.
We should be using scripts from this folder:

/pytorch/.ci/${{ inputs.PACKAGE_TYPE }}/build.sh

TODO: Will followup with removing BUILDER_ROOT everywhere from PyTorch repo

@atalman atalman requested a review from a team as a code owner December 12, 2024 17:44
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143125

Note: Links to docs will display an error until the docs builds have been completed.

❌ 44 New Failures, 2 Cancelled Jobs, 1 Unrelated Failure

As of commit 0a919f5 with merge base 7667235 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 12, 2024
@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Dec 12, 2024
@atalman
Copy link
Contributor Author

atalman commented Dec 12, 2024

@pytorchmergebot merge -f "ModuleNotFoundError: No module named 'packaging' is not related, lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kit1980
Copy link
Contributor

kit1980 commented Dec 12, 2024

@pytorchbot cherry-pick --onto release/2.6 -c critical

@pytorchbot
Copy link
Collaborator

Cherry picking #143125

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x e3fe5f62b6a5caba080201eaba02f8d73a935749 returned non-zero exit code 1

Auto-merging .github/workflows/_binary-build-linux.yml
CONFLICT (content): Merge conflict in .github/workflows/_binary-build-linux.yml
error: could not apply e3fe5f62b6a... Remove Checkout pytorch/builder for Linux Binary Builds (#143125)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

kit1980 added a commit that referenced this pull request Dec 12, 2024
…43131)

Follow Up after: #142282

Remove Checkout pytorch/builder for Linux Binary Builds
I believe we where not using builder already. Hence remove this checkout.
We should be using scripts from this folder:
```
/pytorch/.ci/${{ inputs.PACKAGE_TYPE }}/build.sh
```

TODO: Will followup with removing BUILDER_ROOT everywhere from PyTorch repo
Pull Request resolved: #143125
Approved by: https://github.com/kit1980

Co-authored-by: atalman <atalman@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants