KEMBAR78
[dynamo] Remove transformers ModelOutput hack by anijain2305 · Pull Request #143567 · pytorch/pytorch · GitHub
Skip to content

[dynamo] Remove transformers ModelOutput hack #143567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[dynamo] Remove transformers ModelOutput hack #143567

wants to merge 3 commits into from

Conversation

@anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Dec 19, 2024 •
edited by pytorch-bot bot
Loading

@anijain2305 anijain2305 mentioned this pull request Dec 19, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143567

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ab38b44 with merge base 4f8b7c4 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

anijain2305 added a commit that referenced this pull request Dec 19, 2024
@anijain2305
[dynamo] Remove transformers ModelOutput hack
6e799f1 
ghstack-source-id: 7003d64
Pull Request resolved: #143567
@anijain2305 anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category keep-going Don't stop on first failure, keep running tests until the end labels Dec 19, 2024
@anijain2305
Update on "[dynamo] Remove transformers ModelOutput hack"
08c4317 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Dec 20, 2024
@anijain2305
[dynamo] Remove transformers ModelOutput hack
853c991 
ghstack-source-id: b383fc3
Pull Request resolved: #143567
@anijain2305
Update on "[dynamo] Remove transformers ModelOutput hack"
ab38b44 
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Dec 20, 2024
@anijain2305
[dynamo] Remove transformers ModelOutput hack
d877c95 
ghstack-source-id: cef0668
Pull Request resolved: #143567
@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@anijain2305
Copy link
Contributor Author

@pytorchbot merge -f "flaky CI runner"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

This PR (#143567) was merged in 0da004f but it is still open, likely due to a Github bug, so mergebot is closing it manually. If you think this is a mistake, please feel free to reopen and contact Dev Infra.

cyyever pushed a commit to cyyever/pytorch that referenced this pull request Dec 21, 2024
@anijain2305 @pytorchmergebot
[dynamo] Remove transformers ModelOutput hack (pytorch#143567)
0da004f 
Pull Request resolved: pytorch#143567
Approved by: https://github.com/williamwen42, https://github.com/jansel
ghstack dependencies: pytorch#143548
@anijain2305 anijain2305 mentioned this pull request Dec 27, 2024
Closed
@github-actions github-actions bot deleted the gh/anijain2305/597/head branch January 20, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@williamwen42 williamwen42 williamwen42 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anijain2305 @pytorchmergebot @jansel @williamwen42