KEMBAR78
[inductor] Simplify get_launch_args_* handling by jansel · Pull Request #143835 · pytorch/pytorch · GitHub
Skip to content

[inductor] Simplify get_launch_args_* handling #143835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[inductor] Simplify get_launch_args_* handling #143835

wants to merge 1 commit into from

Conversation

jansel
Copy link
Contributor

@jansel jansel commented Dec 25, 2024 •
edited
Loading

@jansel
Update
5af8d03 
[ghstack-poisoned]
@jansel jansel mentioned this pull request Dec 25, 2024
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 25, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143835

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5af8d03 with merge base a8ac3a6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jansel jansel mentioned this pull request Dec 25, 2024
Closed
This was referenced Dec 25, 2024
Closed
Closed
Closed
@jansel jansel added the ciflow/inductor-rocm Trigger "inductor" config CI on ROCm label Dec 25, 2024
jansel added a commit that referenced this pull request Dec 25, 2024
@jansel
[inductor] Simplify get_launch_args_* handling
3099216 
ghstack-source-id: 97d910f
Pull Request resolved: #143835
@jansel jansel added the topic: not user facing topic category label Dec 25, 2024
@jansel
Copy link
Contributor Author

jansel commented Dec 26, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 26, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

This PR (#143835) was merged in 6bdf2ad but it is still open, likely due to a Github bug, so mergebot is closing it manually. If you think this is a mistake, please feel free to reopen and contact Dev Infra.

@github-actions github-actions bot deleted the gh/jansel/468/head branch January 26, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

@shunting314 shunting314 shunting314 approved these changes

@yanboliang yanboliang Awaiting requested review from yanboliang

Assignees

No one assigned

Labels

ciflow/inductor ciflow/inductor-rocm Trigger "inductor" config CI on ROCm ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jansel @pytorchmergebot @eellison @shunting314