KEMBAR78
[inductor] Refactor CachingAutotuner so that it can pickle by jansel · Pull Request #144044 · pytorch/pytorch · GitHub
Skip to content

Conversation

@jansel
Copy link
Contributor

@jansel jansel commented Jan 1, 2025

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144044

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit 61e3154 with merge base 62ce3e6 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jansel added a commit that referenced this pull request Jan 1, 2025
@jansel jansel added the topic: not user facing topic category label Jan 1, 2025
[ghstack-poisoned]
@jansel jansel changed the title [inductor] Only call triton.compile in worker processes [inductor] Refactor CachingAutotuner so that it can pickle Jan 7, 2025
@jansel jansel marked this pull request as ready for review January 7, 2025 00:22
jansel added 3 commits January 7, 2025 17:34
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@jansel jansel requested a review from eellison January 8, 2025 05:49
"""
xyz_options: tuple[tuple[int, Optional[int], Optional[int]], ...]
configs: List[Config] = []
warp_size = device_props.warp_size
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part got removed and not re-added. not sure if intentional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was unused

"lock": None,
}

def __setstate__(self, state: Dict[str, Any]) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth having any checking of keys ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add an assert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there are a lot of keys, and if we change the params of this object updating the assert would just be a maintence burden.

}
return {**self.__dict__, "kernel": kernel_state} # type: ignore[dict-item]

def __setstate__(self, state: Dict[str, Any]) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question as above..

[ghstack-poisoned]
@jansel
Copy link
Contributor Author

jansel commented Jan 17, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 17, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/jansel/472/head branch February 17, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants