KEMBAR78
Add CUDA 12.8 installation and manylinux-cuda12.8 by tinglvv · Pull Request #145567 · pytorch/pytorch · GitHub
Skip to content

Add CUDA 12.8 installation and manylinux-cuda12.8 #145567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add CUDA 12.8 installation and manylinux-cuda12.8 #145567

wants to merge 7 commits into from

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Jan 24, 2025 •
edited
Loading

Breaking #145557 into two parts.
Need to have manylinux-cuda12.8 in order to build magma.

Issue: #145570

cc @atalman @malfet @ptrblck @nWEIdia

@tinglvv tinglvv requested review from a team and jeffdaily as code owners January 24, 2025 00:42
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145567

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f1227b3 with merge base bdc2c2a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 24, 2025
@cpuhrsch cpuhrsch requested a review from malfet January 24, 2025 03:48
@cpuhrsch cpuhrsch added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 24, 2025
@tinglvv
Copy link
Collaborator Author

tinglvv commented Jan 24, 2025

Build failure

2025-01-24T18:15:14.0693209Z #51 730.1 libnvrtc.alt.so
2025-01-24T18:15:14.0694087Z #51 730.2 nvprune fatal   : Input file '/usr/local/cuda-12.8/lib64/libnvrtc.alt.so' not relocatable

Modify the CUDA Regex to avoid wrongly matching ".alt" when it is searching for ".a" files.

@tinglvv
Copy link
Collaborator Author

tinglvv commented Jan 24, 2025

Build failures with permission denied error. Looks like the tags need to be created

manylinuxaarch64-builder-cuda12.8
manylinux2_28-builder-cuda12.8
manylinux-builder-cuda12.8

cc @atalman @malfet

@johnnynunez
Copy link
Contributor

cc @atalman @malfet

@johnnynunez
Copy link
Contributor

Any progress?

@tinglvv
Copy link
Collaborator Author

tinglvv commented Jan 26, 2025

Waiting for the tags to be created. Should be created next week. I will prepare the other PRs ready so that we can quickly move forward once images are available

@johnnynunez
Copy link
Contributor

Waiting for the tags to be created. Should be created next week. I will prepare the other PRs ready so that we can quickly move forward once images are available

Great! RTX5090 launch is on the 31st!

@nWEIdia
Copy link
Collaborator

nWEIdia commented Jan 26, 2025 •
edited
Loading

https://download.pytorch.org/whl/nightly/cu128 needs to be created, and relevant contents (dependency packages) copied into it.

@tinglvv
Copy link
Collaborator Author

tinglvv commented Jan 27, 2025

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 27, 2025

This PR needs to be approved by an authorized maintainer before merge.

@nWEIdia
Copy link
Collaborator

nWEIdia commented Jan 27, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 27, 2025
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • OSS CI (alband, dagitses, pytorch/pytorch-dev-infra)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 27, 2025 18:33 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 27, 2025 18:33 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 27, 2025 18:33 Inactive
@tinglvv tinglvv mentioned this pull request Jan 27, 2025
Closed
@johnnynunez
Copy link
Contributor

cc @malfet @eqy

atalman
atalman reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman
Copy link
Contributor

atalman commented Jan 27, 2025

@pytorchmergebot merge -f "All required signals are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • OSS CI (alband, dagitses, pytorch/pytorch-dev-infra)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@atalman
Copy link
Contributor

atalman commented Jan 27, 2025

@pytorchmergebot merge -f "All required signals are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

nWEIdia pushed a commit to nWEIdia/pytorch that referenced this pull request Jan 27, 2025
@tinglvv @nWEIdia
Add CUDA 12.8 installation and manylinux-cuda12.8 (pytorch#145567)
a3f598f 
Breaking pytorch#145557 into two parts.
Need to have manylinux-cuda12.8 in order to build magma.

Issue: pytorch#145570

Pull Request resolved: pytorch#145567
Approved by: https://github.com/nWEIdia, https://github.com/atalman
@tinglvv tinglvv mentioned this pull request Jan 27, 2025
Open
26 tasks
@eqy eqy mentioned this pull request Jan 29, 2025
Open
11 tasks
@geo47
Copy link

geo47 commented Mar 5, 2025

I have Cuda 12.8 on my Windows PC, will the Pytorch 2.6.0 with Cuda 12.6 work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@nWEIdia nWEIdia nWEIdia approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tinglvv @johnnynunez @nWEIdia @pytorchmergebot @atalman @geo47 @cpuhrsch @pytorchbot