🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146425

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit c2c2692 with merge base 23fffb5 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@atalman could you import this PR? Thanks!

@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

hi @justinchuby reimported the PR internally will followup with internal team on relanding

@atalman does it look good? Thanks

I am going to remove the deprecation warnings and instead only annotate the methods for now so that we can land this PR. @atalman feel free to let me know when internal usages are updated

@atalman could you re-import?

@atalman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@pytorchbot merge -i

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / linux-focal-rocm6.3-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchbot merge

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

I use torch.onnx.dynamo_export with FakeTensors, like this:

with torch.onnx.enable_fake_mode() as fake_context:
        x = torch.empty((2, 128, 1), dtype=torch.float16)
        model = Transformer(args)
export_options = torch.onnx.ExportOptions(
        fake_context=fake_context
)
export_output = torch.onnx.dynamo_export(
        torch_model, input_data, export_options=export_options
)

how can I use torch.onnx.export(... dynamo=true ...) with FakeTensors inside?

@pytorchmergebot revert -c ghfirst -m "Broke internal tests"

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

Reverting PR 146425 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit 41e6d189a39a40b237ab9b9ab195cec1194b331b returned non-zero exit code 1

Auto-merging torch/onnx/__init__.py
CONFLICT (modify/delete): torch/onnx/_deprecation.py deleted in HEAD and modified in parent of 41e6d189a39 ([ONNX] Create deprecation warning on dynamo_export (#146425)).  Version parent of 41e6d189a39 ([ONNX] Create deprecation warning on dynamo_export (#146425)) of torch/onnx/_deprecation.py left in tree.
Auto-merging torch/onnx/_internal/_exporter_legacy.py
CONFLICT (content): Merge conflict in torch/onnx/_internal/_exporter_legacy.py
Auto-merging torch/onnx/utils.py
Auto-merging torch/onnx/verification.py
CONFLICT (content): Merge conflict in torch/onnx/verification.py
error: could not revert 41e6d189a39... [ONNX] Create deprecation warning on dynamo_export (#146425)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

@pytorchmergebot revert -c ghfirst -m "Broke internal tests"

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@justinchuby your PR has been successfully reverted.

I use torch.onnx.dynamo_export with FakeTensors, like this:

with torch.onnx.enable_fake_mode() as fake_context:
        x = torch.empty((2, 128, 1), dtype=torch.float16)
        model = Transformer(args)
export_options = torch.onnx.ExportOptions(
        fake_context=fake_context
)
export_output = torch.onnx.dynamo_export(
        torch_model, input_data, export_options=export_options
)

how can I use torch.onnx.export(... dynamo=true ...) with FakeTensors inside?

There is no need. torch.export uses faketensors by default. You may also pass in fake tensors as example inputs

Replaced by #146923