ci: Remove manylinux 2014 remnants #148028
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148028
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Cancelled Jobs, 1 PendingAs of commit 481a862 with merge base 723f3a9 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 6 jobs have failed, first few of them are: Build Triton wheels / Build Triton Wheel (3.9, cuda, pytorch/manylinux-builder:cpu), Build Triton wheels / Build Triton Wheel (3.10, cuda, pytorch/manylinux-builder:cpu), Build Triton wheels / Build Triton Wheel (3.11, cuda, pytorch/manylinux-builder:cpu), Build Triton wheels / Build Triton Wheel (3.12, cuda, pytorch/manylinux-builder:cpu), Build Triton wheels / Build Triton Wheel (3.13, cuda, pytorch/manylinux-builder:cpu) Details for Dev Infra teamRaised by workflow job |
| PY_VERS: ${{ matrix.py_vers }} | ||
| BUILD_DEVICE: ${{ matrix.device }} | ||
| PLATFORM: ${{ contains(matrix.docker-image, '2_28') && 'manylinux_2_28_x86_64' || 'manylinux2014_x86_64' }} | ||
| PLATFORM: ${{ contains(matrix.docker-image, '2_28') && 'manylinux_2_28_x86_64' }} |
There was a problem hiding this comment.
This turns PLATFORM into a boolean false when the docker image doesn't contain 2_28 and fails the build, i.e. https://github.com/pytorch/pytorch/actions/runs/13556101092/job/37890623418
| PLATFORM: ${{ contains(matrix.docker-image, '2_28') && 'manylinux_2_28_x86_64' }} | |
| PLATFORM: 'manylinux_2_28_x86_64' |
There was a problem hiding this comment.
I think pytorch/manylinux-builder:cpu on line 49 would also need to be removed
|
@atalman Can I ignore the Triton wheel build failures? It looks like the wheel failures are for the old version of manylinux that we don't support anymore |
These are the only remaining references I could find to manylinux2014, we should probably look to remove these a bit quicker since it made it difficult to know which Dockerfiles were important in .ci/docker/manywheel/ Signed-off-by: Eli Uriegas <eliuriegas@meta.com> ghstack-source-id: 0950613 Pull Request resolved: #148028 Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
These are the only remaining references I could find to manylinux2014, we should probably look to remove these a bit quicker since it made it difficult to know which Dockerfiles were important in .ci/docker/manywheel/ Signed-off-by: Eli Uriegas <eliuriegas@meta.com> ghstack-source-id: a8b0333 Pull Request resolved: #148028 Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
|
@pytorchbot merge -f "unrelated failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
6 participants
Stack from ghstack (oldest at bottom):
These are the only remaining references I could find to manylinux2014,
we should probably look to remove these a bit quicker since it made it
difficult to know which Dockerfiles were important in
.ci/docker/manywheel/
Tip
I checked if we were using these by running
rg 2014 .github/Signed-off-by: Eli Uriegas eliuriegas@meta.com