KEMBAR78
ci: Only run CI specific things when in CI by seemethere · Pull Request #148126 · pytorch/pytorch · GitHub
Skip to content

ci: Only run CI specific things when in CI #148126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

ci: Only run CI specific things when in CI #148126

wants to merge 2 commits into from

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Feb 27, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

This was blocking me from running this locally so don't run it like this

Signed-off-by: Eli Uriegas eliuriegas@meta.com

@seemethere
Update
933c2f6 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 27, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148126

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 50 Pending

As of commit 303340a with merge base 915b9c8 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@seemethere seemethere requested a review from a team February 27, 2025 22:30
@atalman atalman self-requested a review February 27, 2025 22:40
@seemethere
Update
303340a 
[ghstack-poisoned]
@atalman
Copy link
Contributor

atalman commented Feb 27, 2025

I think this patch was required in order not to run into the timeout: pytorch/test-infra#5712

@seemethere
Copy link
Member Author

seemethere commented Feb 27, 2025 •
edited
Loading

I think this patch was required in order not to run into the timeout: pytorch/test-infra#5712

It is but it's also not necessary for anyone running locally and can be pretty intrusive for your local machines, also it makes this impossible to run on non-systemd devices (like mac machines)

atalman
atalman approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@seemethere seemethere mentioned this pull request Feb 27, 2025
Closed
@seemethere
Copy link
Member Author

@pytorchbot merge -f "this passes the things it needs to pass"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Feb 28, 2025
@seemethere @pytorchmergebot
ci: Remove manylinux builds for triton, except for XPU (#148129)
e593288 
We're dropping regular old manylinux so let's drop it here too

Relates to #123649

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Pull Request resolved: #148129
Approved by: https://github.com/Camyll, https://github.com/huydhn, https://github.com/malfet, https://github.com/atalman
ghstack dependencies: #148126
@github-actions github-actions bot deleted the gh/seemethere/10/head branch March 30, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@atalman atalman atalman approved these changes

@Camyll Camyll Camyll approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seemethere @atalman @pytorchmergebot @malfet @Camyll