KEMBAR78
Remove Cuda 12.4 from nightly Binaries by tinglvv · Pull Request #148625 · pytorch/pytorch · GitHub
Skip to content

Remove Cuda 12.4 from nightly Binaries #148625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Remove Cuda 12.4 from nightly Binaries #148625

wants to merge 0 commits into from

Conversation

@tinglvv
Copy link
Collaborator

@tinglvv tinglvv commented Mar 6, 2025

#145570

removes cuda 12.4 nightly builds

cc @atalman @malfet @nWEIdia @ptrblck

@tinglvv tinglvv requested a review from a team as a code owner March 6, 2025 01:08
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148625

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 2 Unrelated Failures

As of commit 79b6740 with merge base 98458e5 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 6, 2025
@tinglvv tinglvv added ciflow/binaries Trigger all binary build and upload jobs on the PR topic: not user facing topic category and removed topic: not user facing topic category labels Mar 6, 2025
@tinglvv tinglvv changed the title Remove Cuda 12.4 nightly binary Remove Cuda 12.4 from nightly Binaries Mar 6, 2025
@tinglvv tinglvv mentioned this pull request Mar 5, 2025
Open
26 tasks
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 6, 2025
atalman
atalman approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman
Copy link
Contributor

atalman commented Mar 7, 2025

@pytorchmergebot merge -f "lint failure can be bypassed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor

malfet commented Mar 7, 2025

@pytorchmergebot revert -m "Broke lint" -c ignoredsignal

@malfet
Copy link
Contributor

malfet commented Mar 7, 2025

See https://hud.pytorch.org/hud/pytorch/pytorch/6602e632cdd4b3780e0a3eb3714ece1981f81bcd/1?per_page=50&name_filter=Lint%20%2F%20workflow

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@tinglvv your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Mar 7, 2025
@pytorchmergebot
Revert "Remove Cuda 12.4 from nightly Binaries (#148625)"
99da439 
This reverts commit 1239176.

Reverted #148625 on behalf of https://github.com/malfet due to Broke lint ([comment](#148625 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Mar 7, 2025
@tinglvv
Copy link
Collaborator Author

tinglvv commented Mar 9, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/13751052494

@tinglvv tinglvv closed this Mar 10, 2025
@huydhn huydhn temporarily deployed to scribe-protected March 10, 2025 18:05 — with GitHub Actions Inactive
@huydhn huydhn had a problem deploying to scribe-protected March 10, 2025 18:05 — with GitHub Actions Failure
@huydhn huydhn temporarily deployed to scribe-protected March 10, 2025 18:05 — with GitHub Actions Inactive
@huydhn huydhn temporarily deployed to scribe-protected March 10, 2025 18:05 — with GitHub Actions Inactive
@huydhn huydhn temporarily deployed to scribe-protected March 10, 2025 18:17 — with GitHub Actions Inactive
@huydhn huydhn temporarily deployed to scribe-protected March 10, 2025 18:17 — with GitHub Actions Inactive
@huydhn huydhn temporarily deployed to scribe-protected March 10, 2025 18:17 — with GitHub Actions Inactive
@huydhn huydhn temporarily deployed to scribe-protected March 10, 2025 18:17 — with GitHub Actions Inactive
@huydhn huydhn temporarily deployed to scribe-protected March 10, 2025 18:17 — with GitHub Actions Inactive
@huydhn huydhn temporarily deployed to scribe-protected March 10, 2025 18:17 — with GitHub Actions Inactive
@huydhn huydhn had a problem deploying to scribe-protected March 10, 2025 18:17 — with GitHub Actions Failure
@tinglvv tinglvv mentioned this pull request Mar 10, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Mar 10, 2025
@tinglvv @pytorchmergebot
Remove 12.4 x86 builds and 12.6 sbsa builds from nightly (#148895)
2a1eeae 
#145570

redo #148625

Pull Request resolved: #148895
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/binaries Trigger all binary build and upload jobs on the PR Merged open source Reverted topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tinglvv @atalman @pytorchmergebot @malfet @huydhn @colesbury @pytorchbot