KEMBAR78
support scalar tensor for functional all_gather by yuguo68 · Pull Request #149913 · pytorch/pytorch · GitHub
Skip to content

support scalar tensor for functional all_gather #149913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

support scalar tensor for functional all_gather #149913

wants to merge 6 commits into from

Conversation

@yuguo68
Copy link
Contributor

@yuguo68 yuguo68 commented Mar 25, 2025 •
edited by pytorch-bot bot
Loading

@yuguo68 yuguo68 mentioned this pull request Mar 25, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149913

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 8b2ad53 with merge base 9b29166 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Mar 25, 2025
yuguo68 added a commit that referenced this pull request Mar 25, 2025
@yuguo68
support scalar tensor for functional all_gather
76de1f0 
ghstack-source-id: 65e6a84
Pull Request resolved: #149913
@yuguo68 yuguo68 requested review from fegin, yf225 and yifuwang March 25, 2025 01:46
@yuguo68
Update on "support scalar tensor for functional all_gather"
8f9423f 
cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
yuguo68 added a commit that referenced this pull request Mar 26, 2025
@yuguo68
support scalar tensor for functional all_gather
e3db320 
ghstack-source-id: a52449a
Pull Request resolved: #149913
@yuguo68 yuguo68 requested a review from wconstab April 4, 2025 00:26
@yuguo68
Update on "support scalar tensor for functional all_gather"
629e381 
cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
yuguo68 added a commit that referenced this pull request May 29, 2025
@yuguo68
support scalar tensor for functional all_gather
5b25aaa 
ghstack-source-id: 18c36e1
Pull Request resolved: #149913
@yuguo68
Update on "support scalar tensor for functional all_gather"
f933b7e 
cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
yuguo68 added a commit that referenced this pull request Jul 24, 2025
@yuguo68
support scalar tensor for functional all_gather
5613ce5 
ghstack-source-id: 54a40b8
Pull Request resolved: #149913
@yuguo68
Copy link
Contributor Author

yuguo68 commented Jul 24, 2025

to fix #154621

@yuguo68 yuguo68 requested review from H-Huang and kwen2501 July 24, 2025 20:36
@yuguo68
Copy link
Contributor Author

yuguo68 commented Jul 24, 2025

@H-Huang, @kwen2501 could you help review? thanks!

@yuguo68
Update on "support scalar tensor for functional all_gather"
9485744 
cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
yuguo68 added a commit that referenced this pull request Jul 24, 2025
@yuguo68
support scalar tensor for functional all_gather
9b7d7d1 
ghstack-source-id: 34075a1
Pull Request resolved: #149913
@yuguo68
Update on "support scalar tensor for functional all_gather"
8b2ad53 
cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
yuguo68 added a commit that referenced this pull request Jul 25, 2025
@yuguo68
support scalar tensor for functional all_gather
ca769bc 
ghstack-source-id: a34a827
Pull Request resolved: #149913
H-Huang
H-Huang approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@H-Huang H-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding!

@yuguo68
Copy link
Contributor Author

yuguo68 commented Jul 25, 2025

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 25, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4)

Details for Dev Infra team Raised by workflow job

@yuguo68
Copy link
Contributor Author

yuguo68 commented Jul 25, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable), trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@yuguo68 @yangw-dev
support scalar tensor for functional all_gather (#149913)
180d1cf 
Pull Request resolved: #149913
Approved by: https://github.com/H-Huang
ghstack dependencies: #149912
@github-actions github-actions bot deleted the gh/yuguo68/2/head branch August 25, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@H-Huang H-Huang H-Huang approved these changes

@yf225 yf225 Awaiting requested review from yf225

@yifuwang yifuwang Awaiting requested review from yifuwang

@fegin fegin Awaiting requested review from fegin

@wconstab wconstab Awaiting requested review from wconstab

@kwen2501 kwen2501 Awaiting requested review from kwen2501

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuguo68 @pytorchmergebot @H-Huang