Inductor respects exact strides on custom ops by default #150511

zou3519 · 2025-04-02T04:07:30Z

Stack from ghstack (oldest at bottom):

If a tag is not specified on a custom operator, then inductor will
assume that it needs exact strides.

Test Plan:

tests + CI

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]

pytorch-bot · 2025-04-02T04:07:33Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150511

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

CI workflows being skipped on PR

✅ No Failures

As of commit 052aae3 with merge base e9e1aac ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI ghstack-source-id: 044da00 Pull Request resolved: #150511

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI ghstack-source-id: c35062d Pull Request resolved: #150511

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]

eellison

🚀 🚀 🚀

Can you add a check ops with this tag here:

pytorch/torch/_inductor/graph.py

Lines 239 to 251 in 8102272

    
           for cur in reversed(g.nodes): 
        
               if isinstance( 
        
                   cur.target, 
        
                   torch._higher_order_ops.triton_kernel_wrap.TritonKernelWrapperMutation, 
        
               ): 
        
                   cur.meta["dislike_padding"] = True 
        
                   continue 
        
               op = _get_overload_packet(cur) 
        
               if not op: 
        
                   continue 
        
               if op in ops_dislike_padding: 
        
                   cur.meta["dislike_padding"] = True

?

zou3519 · 2025-04-02T17:33:46Z

@eellison to make sure I understand, we are saying that if an operator has needs_exact_strides, then we should set dislike_padding on it too?

eellison · 2025-04-02T17:46:47Z

Yes, thats correct

zou3519 · 2025-04-02T18:02:00Z

Cool, going to put that into the PR below this one (I want this PR to be mostly just the config switch so that it's easy to revert)

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI ghstack-source-id: 1df8387 Pull Request resolved: #150511

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI ghstack-source-id: 97522c1 Pull Request resolved: #150511

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI ghstack-source-id: 99e0ac0 Pull Request resolved: #150511

pytorchmergebot · 2025-04-09T16:41:07Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…0511)" This reverts commit a4bb2f1. Reverted #150511 on behalf of https://github.com/atalman due to [GH job link](https://github.com/pytorch/pytorch/actions/runs/14357056427/job/40251630946) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/2e7c9d33e7f933ac3b723cb3bb05b9c88432c25c) ([comment](#148104 (comment)))

pytorchmergebot · 2025-04-09T16:49:51Z

@zou3519 your PR has been successfully reverted.

) If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI Pull Request resolved: pytorch#150511 Approved by: https://github.com/eellison, https://github.com/shunting314 ghstack dependencies: pytorch#150495, pytorch#148104

…orch#150511)" This reverts commit a4bb2f1. Reverted pytorch#150511 on behalf of https://github.com/atalman due to [GH job link](https://github.com/pytorch/pytorch/actions/runs/14357056427/job/40251630946) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/2e7c9d33e7f933ac3b723cb3bb05b9c88432c25c) ([comment](pytorch#148104 (comment)))

) If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI Pull Request resolved: pytorch#150511 Approved by: https://github.com/eellison, https://github.com/shunting314 ghstack dependencies: pytorch#150495, pytorch#148104

…orch#150511)" This reverts commit a4bb2f1. Reverted pytorch#150511 on behalf of https://github.com/atalman due to [GH job link](https://github.com/pytorch/pytorch/actions/runs/14357056427/job/40251630946) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/2e7c9d33e7f933ac3b723cb3bb05b9c88432c25c) ([comment](pytorch#148104 (comment)))

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI Pull Request resolved: #150511 Approved by: https://github.com/eellison, https://github.com/shunting314 ghstack dependencies: #150495, #148104 ghstack-source-id: 7192ed4

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI Pull Request resolved: #150511 Approved by: https://github.com/eellison, https://github.com/shunting314 ghstack dependencies: #150495, #148104 ghstack-source-id: 4ef6024

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI Pull Request resolved: #150511 Approved by: https://github.com/eellison, https://github.com/shunting314 ghstack dependencies: #150495, #148104 ghstack-source-id: 923efe0

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI Pull Request resolved: #150511 Approved by: https://github.com/eellison, https://github.com/shunting314 ghstack dependencies: #150495, #148104 ghstack-source-id: f095c0a

zou3519 · 2025-05-02T23:54:30Z

@pytorchbot merge

pytorchmergebot · 2025-05-02T23:56:36Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Inductor respects exact strides on custom ops by default

e6d3d15

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]

This was referenced Apr 2, 2025

Change arg_kwarg_vals propagation strategy #148046

Closed

Add needs_exact_strides operator tag for Inductor to force exact strides #148063

Closed

This was referenced Apr 2, 2025

Implement needs_exact_strides for mutable custom operators #148091

Closed

Rename node.meta["arg_kwarg_vals"] to node.meta["eager_input_vals"] #148092

Closed

pytorch-bot bot added ciflow/inductor module: inductor labels Apr 2, 2025

This was referenced Apr 2, 2025

Fix _del_library #150495

Closed

Refactor layout constraint selection logic #148104

Closed

Update on "Inductor respects exact strides on custom ops by default"

43ccdcb

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]

zou3519 requested review from eellison and shunting314 April 2, 2025 13:30

zou3519 added the release notes: inductor label Apr 2, 2025

eellison approved these changes Apr 2, 2025

View reviewed changes

Update on "Inductor respects exact strides on custom ops by default"

120a1f0

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]

Update on "Inductor respects exact strides on custom ops by default"

a8f1b25

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]

shunting314 approved these changes Apr 8, 2025

View reviewed changes

Update on "Inductor respects exact strides on custom ops by default"

bca5ef2

If a tag is not specified on a custom operator, then inductor will assume that it needs exact strides. Test Plan: - tests + CI [ghstack-poisoned]

zou3519 added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 8, 2025

pytorchmergebot added the Merged label Apr 9, 2025

pytorchmergebot closed this in a4bb2f1 Apr 9, 2025

pytorchmergebot removed the merging label Apr 9, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Apr 9, 2025

pytorchmergebot reopened this Apr 9, 2025

zou3519 added 2 commits May 1, 2025 09:31

pytorchmergebot added the merging label May 2, 2025

pytorchmergebot closed this in 3d777ba May 3, 2025

pytorchmergebot removed the merging label May 3, 2025

github-actions bot deleted the gh/zou3519/1152/head branch June 15, 2025 02:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Inductor respects exact strides on custom ops by default #150511

Inductor respects exact strides on custom ops by default #150511

Uh oh!

zou3519 commented Apr 2, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Apr 2, 2025 •

edited

Loading

Uh oh!

eellison left a comment

Uh oh!

zou3519 commented Apr 2, 2025

Uh oh!

eellison commented Apr 2, 2025

Uh oh!

zou3519 commented Apr 2, 2025

Uh oh!

pytorchmergebot commented Apr 9, 2025

Uh oh!

pytorchmergebot commented Apr 9, 2025

Uh oh!

zou3519 commented May 2, 2025

Uh oh!

pytorchmergebot commented May 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	for cur in reversed(g.nodes):
	if isinstance(
	cur.target,
	torch._higher_order_ops.triton_kernel_wrap.TritonKernelWrapperMutation,
	):
	cur.meta["dislike_padding"] = True
	continue

	op = _get_overload_packet(cur)
	if not op:
	continue
	if op in ops_dislike_padding:
	cur.meta["dislike_padding"] = True

Inductor respects exact strides on custom ops by default #150511

Inductor respects exact strides on custom ops by default #150511

Uh oh!

Conversation

zou3519 commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150511

❗ 1 Active SEVs

✅ No Failures

Uh oh!

eellison left a comment

Choose a reason for hiding this comment

Uh oh!

zou3519 commented Apr 2, 2025

Uh oh!

eellison commented Apr 2, 2025

Uh oh!

zou3519 commented Apr 2, 2025

Uh oh!

pytorchmergebot commented Apr 9, 2025

Merge started

Uh oh!

pytorchmergebot commented Apr 9, 2025

Uh oh!

zou3519 commented May 2, 2025

Uh oh!

pytorchmergebot commented May 2, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zou3519 commented Apr 2, 2025 •

edited

Loading

pytorch-bot bot commented Apr 2, 2025 •

edited

Loading